Image edition before sending: crop and rotate.#6842
Merged
Conversation
* feat(messages): add crop and rotate before image upload * Update screenshots * chore: trigger CI after screenshot update * fix: resolve detekt violations in image editor and media viewer modules * fix: require explicit edits param, use plurals for rotation a11y, remove redundant @Inject * fix: require explicit edits param, use plurals for rotation a11y, remove redundant @Inject * fix: use semantically correct RotateRight icon for image rotation action * Update screenshots * chore: trigger CI after screenshot update --------- Co-authored-by: ElementBot <android@element.io> Co-authored-by: Benoit Marty <benoitm@element.io>
Update and add tests Improve preview
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6842 +/- ##
===========================================
- Coverage 81.25% 81.17% -0.08%
===========================================
Files 2652 2657 +5
Lines 74373 75100 +727
Branches 9641 9748 +107
===========================================
+ Hits 60432 60966 +534
- Misses 10381 10535 +154
- Partials 3560 3599 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…etection to the parent node and offsetting the touch events
bmarty
added
the
Record-Screenshots
github-actions
Bot
removed
the
Record-Screenshots
|
jmartinesp
approved these changes
May 26, 2026
jmartinesp
left a comment
jmartinesp
left a comment
Member
There was a problem hiding this comment.
It works quite well now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Follow up for #6363.
See #6363 comments for the specifications. What is implemented today:
1 second after releasing, the image automatically crops and resizes/recenters in the middle of the screen. This would require more work since the code was not design to work like this. I am not sure that this is a good idea though, without having a way to cancel the last cropping: the user will have no way to increase the crop size without having to reset everything.Note: this does not bring gallery support, for now only one image can be sent at a time, edited or not.
Extra things:
Motivation and context
Closes #2676
Screenshots / GIFs
See recorded one.
Tests
Tested devices
Checklist