Skip to content

Downgrade detekt compose rules#6846

Open
bmarty wants to merge 5 commits into
developfrom
fix/downgrade-detekt
Open

Downgrade detekt compose rules#6846
bmarty wants to merge 5 commits into
developfrom
fix/downgrade-detekt

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented May 22, 2026

Content

Downgrade io.nlopez.compose.rules:detekt from 0.5.8 to 0.4.28 as there are incompatility with the version of detekt we are using and issues are not detected anymore. Also fix the existing issues on develop.

Co-authored by @jmartinesp who made the main part of the changes

Motivation and context

Ensure that issues are detected and fixed before we merge a PR.

Screenshots / GIFs

No impact

Tests

  • make a code issue by instance by using several time the modifier. Now detekt should report an error.

Tested devices

  • NA

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner May 22, 2026 12:59
@bmarty bmarty requested review from ganfra and removed request for a team May 22, 2026 12:59
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iaEPd1

@sonarqubecloud
Copy link
Copy Markdown

@ElementBot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️

gradle/libs.versions.toml#L6 - A newer version of com.android.tools.build:gradle than 8.13.2 is available: 9.2.1

⚠️

gradle/libs.versions.toml#L25 - A newer version of androidx.compose:compose-bom than 2026.05.00 is available: 2026.05.01

⚠️

gradle/libs.versions.toml#L35 - A newer version of io.github.takahirom.roborazzi:roborazzi-junit-rule than 1.60.0 is available: 1.63.0

⚠️

gradle/libs.versions.toml#L54 - A newer version of com.autonomousapps:dependency-analysis-gradle-plugin than 3.12.0 is available: 3.13.0

⚠️

gradle/libs.versions.toml#L65 - A newer version of io.nlopez.compose.rules:detekt than 0.4.28 is available: 0.5.9

⚠️

gradle/libs.versions.toml#L105 - A newer version of androidx.javascriptengine:javascriptengine than 1.0.0 is available: 1.1.0

⚠️

gradle/libs.versions.toml#L128 - A newer version of androidx.compose.material3:material3 than 1.5.0-alpha15 is available: 1.5.0-alpha20

⚠️

gradle/libs.versions.toml#L217 - A newer version of org.maplibre.compose:maplibre-compose than 0.12.1 is available: 0.13.0

⚠️

gradle/libs.versions.toml#L229 - A newer version of com.posthog:posthog-android than 3.43.0 is available: 3.45.0

⚠️

gradle/libs.versions.toml#L230 - A newer version of io.sentry:sentry-android than 8.41.0 is available: 8.42.0

⚠️

gradle/libs.versions.toml#L272 - A newer version of app.cash.paparazzi than 2.0.0-alpha04 is available: 2.0.0-alpha05

⚠️

libraries/architecture/src/main/kotlin/io/element/android/libraries/architecture/appyx/SafeChildrenTransitionScope.kt#L67 - Composable functions that return Unit should start with an uppercase letter

⚠️

libraries/architecture/src/main/kotlin/io/element/android/libraries/architecture/appyx/SafeChildrenTransitionScope.kt#L77 - Composable functions that return Unit should start with an uppercase letter

Generated by 🚫 dangerJS against fa2fd8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Build For changes related to build, tools, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants