Skip to content

Move empty day separator filtering to a timeline post-processor#6866

Merged
jmartinesp merged 2 commits into
developfrom
misc/move-empty-day-filtering-to-timeline-post-processor
May 26, 2026
Merged

Move empty day separator filtering to a timeline post-processor#6866
jmartinesp merged 2 commits into
developfrom
misc/move-empty-day-filtering-to-timeline-post-processor

Conversation

@jmartinesp

Copy link
Copy Markdown
Member

Content

A refactor of the code previously added in #6360.

This follows our current model better than applying the filtering in the RoomBeginningPostProcessor and then on the mapped timeline items.

Motivation and context

Better consistency with the existing code.

Tests

Everything should work as before, some unit tests were added, others simply moved.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 15

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp requested a review from a team as a code owner May 26, 2026 07:52
@jmartinesp jmartinesp removed the request for review from a team May 26, 2026 07:52
@jmartinesp jmartinesp added the PR-Change For updates to an existing feature label May 26, 2026
@jmartinesp jmartinesp requested a review from ganfra May 26, 2026 07:52
@github-actions

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bAX4jB

@sonarqubecloud

Copy link
Copy Markdown

@ganfra ganfra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jmartinesp jmartinesp enabled auto-merge (squash) May 26, 2026 08:19
@jmartinesp jmartinesp merged commit 1e67c2f into develop May 26, 2026
37 checks passed
@jmartinesp jmartinesp deleted the misc/move-empty-day-filtering-to-timeline-post-processor branch May 26, 2026 08:28
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.26%. Comparing base (f447560) to head (04dda8a).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...ssor/FilterPublicMembershipChangesPostProcessor.kt 80.00% 0 Missing and 2 partials ⚠️
...eline/postprocessor/FilterEmptyDayPostProcessor.kt 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6866      +/-   ##
===========================================
- Coverage    81.26%   81.26%   -0.01%     
===========================================
  Files         2652     2654       +2     
  Lines        74404    74411       +7     
  Branches      9650     9650              
===========================================
+ Hits         60463    60467       +4     
- Misses       10378    10381       +3     
  Partials      3563     3563              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Change For updates to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants