Move empty day separator filtering to a timeline post-processor#6866
Merged
jmartinesp merged 2 commits intoMay 26, 2026
Merged
Conversation
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6866 +/- ##
===========================================
- Coverage 81.26% 81.26% -0.01%
===========================================
Files 2652 2654 +2
Lines 74404 74411 +7
Branches 9650 9650
===========================================
+ Hits 60463 60467 +4
- Misses 10378 10381 +3
Partials 3563 3563 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Content
A refactor of the code previously added in #6360.
This follows our current model better than applying the filtering in the
RoomBeginningPostProcessorand then on the mapped timeline items.Motivation and context
Better consistency with the existing code.
Tests
Everything should work as before, some unit tests were added, others simply moved.
Tested devices
Checklist