Refactor: replace client-side event filtering for public rooms with SDK#7025
Merged
jmartinesp merged 3 commits intoJun 16, 2026
Conversation
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Member
Author
|
Flaky test spotted? |
bmarty
approved these changes
Jun 16, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7025 +/- ##
===========================================
- Coverage 80.64% 80.61% -0.03%
===========================================
Files 2678 2676 -2
Lines 76229 76217 -12
Branches 10252 10249 -3
===========================================
- Hits 61474 61444 -30
- Misses 10824 10844 +20
+ Partials 3931 3929 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Replace
FilterPublicEmptyDayPostProcessorandFilterPublicMembershipChangesPostProcessorwith some simple SDK timeline filters.Motivation and context
Replace and simplify #6360
Tests
The app should behave just as it did: join and leave events and display name / avatar url changes in publicly accessible, non-encrypted rooms should be hidden. Since the filter happens in the SDK, day dividers for empty days should also be removed automatically.
Tested devices
Checklist