Skip to content

Refactor: replace client-side event filtering for public rooms with SDK#7025

Merged
jmartinesp merged 3 commits into
developfrom
refactor/replace-client-based-public-room-event-filtering-with-rust-one
Jun 16, 2026
Merged

Refactor: replace client-side event filtering for public rooms with SDK#7025
jmartinesp merged 3 commits into
developfrom
refactor/replace-client-based-public-room-event-filtering-with-rust-one

Conversation

@jmartinesp

Copy link
Copy Markdown
Member

Content

Replace FilterPublicEmptyDayPostProcessor and FilterPublicMembershipChangesPostProcessor with some simple SDK timeline filters.

Motivation and context

Replace and simplify #6360

Tests

The app should behave just as it did: join and leave events and display name / avatar url changes in publicly accessible, non-encrypted rooms should be hidden. Since the filter happens in the SDK, day dividers for empty days should also be removed automatically.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 15

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp requested a review from a team as a code owner June 15, 2026 13:19
@jmartinesp jmartinesp requested review from bmarty and removed request for a team June 15, 2026 13:19
@jmartinesp jmartinesp added the PR-Change For updates to an existing feature label Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/z63qCD

@jmartinesp

Copy link
Copy Markdown
Member Author

Flaky test spotted?

> Task :features:linknewdevice:impl:testDebugUnitTest

ScanQrCodeViewTest > try again button clicked - emits the expected event FAILED
    java.lang.IllegalArgumentException at ScanQrCodeViewTest.kt:83

@bmarty bmarty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jmartinesp and others added 2 commits June 16, 2026 13:16
Co-authored-by: Benoit Marty <benoitm@element.io>
@jmartinesp jmartinesp enabled auto-merge (squash) June 16, 2026 12:10
@jmartinesp jmartinesp merged commit 19ee0ae into develop Jun 16, 2026
28 of 31 checks passed
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.61%. Comparing base (a3a0fda) to head (4656e01).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...ies/matrix/impl/room/TimelineEventFilterFactory.kt 0.00% 11 Missing ⚠️
...roid/libraries/matrix/impl/room/RustRoomFactory.kt 0.00% 9 Missing ⚠️
...droid/libraries/matrix/impl/room/JoinedRustRoom.kt 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7025      +/-   ##
===========================================
- Coverage    80.64%   80.61%   -0.03%     
===========================================
  Files         2678     2676       -2     
  Lines        76229    76217      -12     
  Branches     10252    10249       -3     
===========================================
- Hits         61474    61444      -30     
- Misses       10824    10844      +20     
+ Partials      3931     3929       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp deleted the refactor/replace-client-based-public-room-event-filtering-with-rust-one branch June 16, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Change For updates to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants