Add read all messages feature#7049
Conversation
# Conflicts: # features/home/impl/src/test/kotlin/io/element/android/features/home/impl/roomlist/RoomListPresenterTest.kt
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
|
@bmarty rewriten according to your feedback #6828 (comment) |
# Conflicts: # features/home/impl/src/main/kotlin/io/element/android/features/home/impl/roomlist/RoomListPresenter.kt # features/home/impl/src/test/kotlin/io/element/android/features/home/impl/roomlist/RoomListPresenterTest.kt
jmartinesp
left a comment
There was a problem hiding this comment.
Oh, sorry for the late review. I wasn't paying much attention to notifications about this PR because I was sure someone else had taken over the review 🤦 .
The code looks mostly fine to me. I'll add the strings to localazy and merge it if there are no problems with the CI. Thanks, and sorry for the delay again 🙏 .
|
@hghgrtut could you fix the lint issues before merging (unused imports, Also, a small nit:
Since the 'footer' text is added next to the Actually, since I'm adding the strings to the PR I might as well fix those real quick too. |
… with `MarkAllRoomsAsRead(val needsConfirmation: Boolean)` and a `AsyncAction.Confirming` state
… strings for the developer settings
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7049 +/- ##
===========================================
- Coverage 80.55% 80.54% -0.02%
===========================================
Files 2687 2689 +2
Lines 76381 76433 +52
Branches 10282 10291 +9
===========================================
+ Hits 61530 61560 +30
- Misses 10920 10939 +19
- Partials 3931 3934 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

Content
Add functionality to read all messages in all rooms by one tap. Element X already has this functionality on iOs (https://github.com/element-hq/element-x-ios/pull/5582/changes)
Motivation and context
element-hq/element-meta#2682
Can be useful for example if you work at support and need to clear focus before your next work day.
Already added to iOs element-hq/element-x-ios#5582
Screenshots / GIFs
Tests
Tested devices
Checklist