Allow homeserver to disable encryption in Element Pro#7198
Conversation
Add `force_disable_e2ee` support in the Element well known retriever and cache to allow a homeserver to disable encrypted room creation and enabling encryption in an existing room in Element Pro clients
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7198 +/- ##
========================================
Coverage 80.53% 80.54%
========================================
Files 2730 2730
Lines 78927 78943 +16
Branches 10695 10696 +1
========================================
+ Hits 63567 63581 +14
- Misses 11222 11223 +1
- Partials 4138 4139 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I think basically any deployment that trust its own server would want this feature as well? Why is this Element Pro? |
I think Element's strategy is using E2EE chats as much as possible, this is mostly a workaround to allow some customers to upgrade their Element Classic users to Element X, and we made it this way mainly because we didn't think community users would be interested in it and because it's way faster than adding an MSC for it, but I don't think we'd be against implementing a proper MSC with a similar goal if it existed (cc @mxandreas maybe?). |
|
Yes, our goal is to generally optimize the clients for E2EE (Pro or not) as optimizing for "everything" tends to lead poor experience for everybody or a more complex product that is harder to understand, configure, maintain and further enhance. Having said that, we don't of course do anything intentionally to just block non-E2EE usage - this only applies when we have to make compromises. Therefore, yes, we do not want to put the disabling of E2EE into our clients generally - it is rather keeping backward compatibility with what existed before for those who have paid for that in the past. |
|



Content
Add
force_disable_e2eesupport in the Element well known retriever and cache.Use it to disable creating rooms with e2ee enabled or enabling encryption in existing ones.
Motivation and context
Allowing a homeserver to disable encrypted room creation and disable enabling encryption in an existing room in Element Pro clients.
Tests
DefaultSessionEnterpriseService.isEncryptionDisabledByHomeserverto return true.Tested devices
Checklist