Do not show membership/profile events in public rooms#5698
Conversation
|
Sorry, this should be done in the SDK, we shouldn't be filtering out things like this at the application layer. There's already a filtering mechanism in place that could be used, although I've been told it would need extending slightly. It would also mean that we only have to maintain the code (and tests) in a single place and have better guarantees about the behaviour on both platforms. |
|
@pixlwave that was also my suspicion, but it seems like it was OK in Android? @jmartinesp |
|
After taking a closer look, it seems like this could mostly be done in the SDK as is now, it would just need some extra filtering for the type of membership changes to exclude using |
Port of element-hq/element-x-android#6360
Sorry for the AI slop, didn't test it, though there are unit tests. This is pretty simple so I assume it should work as-is without problems.
The expected behavior is: "user joined/left/changed display name/avatar" are not shown if the room's join rule isn't
invite, the current code seems to do it.Pull Request Checklist
UI changes have been tested with: