Skip to content

Do not show membership/profile events in public rooms#5698

Closed
bxdxnn wants to merge 1 commit into
element-hq:developfrom
bxdxnn:misc/filter-membership
Closed

Do not show membership/profile events in public rooms#5698
bxdxnn wants to merge 1 commit into
element-hq:developfrom
bxdxnn:misc/filter-membership

Conversation

@bxdxnn

@bxdxnn bxdxnn commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Port of element-hq/element-x-android#6360
Sorry for the AI slop, didn't test it, though there are unit tests. This is pretty simple so I assume it should work as-is without problems.
The expected behavior is: "user joined/left/changed display name/avatar" are not shown if the room's join rule isn't invite, the current code seems to do it.

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@bxdxnn
bxdxnn requested a review from a team as a code owner June 3, 2026 11:26
@bxdxnn
bxdxnn requested review from Velin92 and removed request for a team June 3, 2026 11:26
@bxdxnn bxdxnn changed the title Filter membership changes in public rooms Do not show membership/profile events in public rooms Jun 3, 2026
@pixlwave

pixlwave commented Jun 3, 2026

Copy link
Copy Markdown
Member

Sorry, this should be done in the SDK, we shouldn't be filtering out things like this at the application layer. There's already a filtering mechanism in place that could be used, although I've been told it would need extending slightly. It would also mean that we only have to maintain the code (and tests) in a single place and have better guarantees about the behaviour on both platforms.

@pixlwave pixlwave closed this Jun 3, 2026
@bxdxnn

bxdxnn commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@pixlwave that was also my suspicion, but it seems like it was OK in Android? @jmartinesp

@jmartinesp

Copy link
Copy Markdown
Member

After taking a closer look, it seems like this could mostly be done in the SDK as is now, it would just need some extra filtering for the type of membership changes to exclude using TimelineItemFilter. If I have the time I'll come back to this and try to make it work through the SDK.

@bxdxnn
bxdxnn deleted the misc/filter-membership branch June 3, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants