Fix a bug which could corrupt auth chains#18746
Merged
Merged
Conversation
1 task
1 task
MadLittleMods
approved these changes
Jul 29, 2025
erikjohnston
approved these changes
Aug 14, 2025
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complement tests
Basically, when we use
/state_idsin conjunction with/eventrequests, the/eventrequest can fail causing a partial state to be returned. When we persist the state, we process dependent events first. If we fail to process a dependent event due to missing theauth_event, we didn't update the in-memory event map. This meant that we could incorrectly persist events that depended on dropped events.Discovered via Chaos testing.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.