-
Notifications
You must be signed in to change notification settings - Fork 526
Improve SSO/delegated authentication worker docs #19752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benbz
wants to merge
4
commits into
develop
Choose a base branch
from
bbz/improve-mas-admin-api-docs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
defd7c3
Highlight that some endpoints are only available in experimental MAS …
benbz 06f007c
Fix endpoints handled by DeviceRestServlet and DevicesRestServlet
benbz f0d7eb8
Document stabilised delegated authentication workers
benbz f6b33b6
Highlight that the SSO paths aren't need if either form of delegated …
benbz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Document the paths that can be handled on workers with stabilised delegated authentication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Improve documentation around endpoints that can be enabled with MSC3861. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -290,6 +290,9 @@ information. | |
| # Unstable MSC4140 support | ||
| ^/_matrix/client/unstable/org.matrix.msc4140/delayed_events(/.*/restart)?$ | ||
|
|
||
| # Stabilised Delegated Authentication support (`matrix_authentication_service.enabled: true`) | ||
| ^/_synapse/mas/ | ||
|
|
||
| Additionally, the following REST endpoints can be handled for GET requests: | ||
|
|
||
| # Push rules requests | ||
|
|
@@ -314,7 +317,7 @@ for the room are in flight: | |
|
|
||
| Additionally, the following endpoints should be included if Synapse is configured | ||
| to use SSO (you only need to include the ones for whichever SSO provider you're | ||
| using): | ||
| using) and delegated authentication isn't enabled: | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've made the assertion here that none of these paths are useful in delegated auth world (be it experimental config or stabilised) |
||
|
|
||
| # for all SSO providers | ||
| ^/_matrix/client/(api/v1|r0|v3|unstable)/login/sso/redirect | ||
|
|
@@ -343,7 +346,11 @@ set to `true`), the following endpoints can be handled by the worker: | |
| ^/_synapse/admin/v2/users/[^/]+$ | ||
| ^/_synapse/admin/v1/username_available$ | ||
| ^/_synapse/admin/v1/users/[^/]+/_allow_cross_signing_replacement_without_uia$ | ||
| ^/_synapse/admin/v1/users/[^/]+/devices$ | ||
| ^/_synapse/admin/v2/users/[^/]+/devices(/|$) | ||
|
|
||
| Do note that these endpoints can't be handled by workers if the stabilised delegated | ||
| authentication support is enabled (`matrix_authentication_service.enabled` set to | ||
| `true`). | ||
|
|
||
| Note that a [HTTP listener](usage/configuration/config_documentation.md#listeners) | ||
| with `client` and `federation` `resources` must be configured in the | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented up here rather than next to the
experimental_features.msc3861.enabledpaths as AFAICT it can be handled by any worker rather than a worker with a single process only