Allow 3rd party rules check_event_allowed callback to function for room version "12" creation events#19768
Open
jason-famedly wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to room version "12" removes that a room ID is included in the room creation event, and is instead generated based on the event hash of said event. This seems to break the
check_event_allowed()callback for this room version specifically for creation events due to anassertin the function that expects a room ID to be present.Specifically ignore that assertion for creation events on rooms that support MSC4291(Room ID's as hashes) to fix this. This also needs to be checked for the correct assumptions about MSC4242 taken in it's second half(that creation events do not contain
prev_state_eventsin the same way that they do not includeprev_events)Note this contains a commit that should be reverted before merging, that overrides the test so room version "12" is used
💡 This is the command line to run the specific test:
poetry run trial tests.rest.client.test_third_party_rules.ThirdPartyRulesTestCase.test_legacy_check_event_allowedFailure looked like this before:
(There is another error in this TestCase when using room version "12", but it is unrelated to this and will be handled separately when fixing the tests themselves)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.