Fix fusion: use pytz.utc instead of datetime.timezone.utc; fix brittle test timezone

- sla_utils.sql: replace datetime.timezone.utc with pytz.utc in fusion path.
  dbt-fusion's modules.datetime does not expose datetime.timezone, causing
  dbt1501 "undefined value" errors in all data_freshness_sla tests on fusion.

- test_data_freshness_sla.py: change test_deadline_not_passed_does_not_fail
  from Etc/GMT-14 (UTC+14, deadline = 09:59 UTC) to plain UTC (deadline = 23:59 UTC).
  Etc/GMT-14 caused the test to fail whenever CI ran after 09:59 UTC.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: joostboon

integration_tests/tests/test_data_freshness_sla.py

@@ -67,13 +67,12 @@ def test_deadline_not_passed_does_not_fail(test_id: str, dbt_project: DbtProject
     data = [
         {TIMESTAMP_COLUMN: yesterday.strftime(DATE_FORMAT)},
     ]
-    # Set the deadline far in the future so it hasn't passed yet.
-    # Etc/GMT-14 is UTC+14, the farthest-ahead timezone, so 11:59pm there
-    # is well into the future from UTC's perspective.
+    # Set the deadline to 11:59pm UTC so it reliably hasn't passed yet.
+    # (Etc/GMT-14 = UTC+14 means 11:59pm there = 09:59 UTC — not reliably future)
     test_args = {
         "timestamp_column": TIMESTAMP_COLUMN,
         "sla_time": "11:59pm",
-        "timezone": "Etc/GMT-14",
+        "timezone": "UTC",
     }
     test_result = dbt_project.test(test_id, TEST_NAME, test_args, data=data)
     assert test_result["status"] == "pass"

macros/edr/tests/test_utils/sla_utils.sql

@@ -52,33 +52,29 @@
         'target_date': string (YYYY-MM-DD),
         'target_date_start_utc': string (YYYY-MM-DD HH:MM:SS) - start of day in UTC,
         'target_date_end_utc': string (YYYY-MM-DD HH:MM:SS) - end of day in UTC,
-        'day_of_week': string (e.g. 'Monday'),
-        'day_of_month': integer (1-31)
+        'deadline_passed': boolean
     }
 #}
 {% macro calculate_sla_deadline_utc(sla_hour, sla_minute, timezone) %}
     {% set datetime = modules.datetime %}
     {% set pytz = modules.pytz %}
 
     {% if elementary.is_dbt_fusion() %}
-        {# dbt-fusion's pytz and timezone-aware datetime operations have known issues
-           (dbt-labs/dbt-fusion#143). Use naive UTC datetimes with manual offset
-           calculation to avoid broken localize() and datetime comparison.
-           Known limitation: on DST transition days, boundary times (midnight,
-           SLA deadline) may be off by ~1 hour since we reuse a single offset.
-           The dbt-core path below handles DST correctly. #}
-        {% set utc_tz = pytz.timezone("UTC") %}
+        {# dbt-fusion's pytz.localize() is unreliable (dbt-labs/dbt-fusion#143).
+           Use stdlib datetime.timezone.utc to create a proper UTC-aware datetime,
+           then call astimezone(pytz_tz) which uses pytz's fromutc() internally —
+           more reliable than localize(). #}
         {% set target_tz = pytz.timezone(timezone) %}
 
-        {# Get current UTC time as naive datetime - reliable across environments #}
-        {% set now_utc = datetime.datetime.utcnow() %}
+        {# Create a UTC-aware datetime using pytz.utc — avoids datetime.timezone which
+           is not exposed in fusion's modules.datetime (dbt-labs/dbt-fusion#143) #}
+        {% set now_utc_aware = datetime.datetime.now(pytz.utc) %}
+        {% set now_local = now_utc_aware.astimezone(target_tz) %}
+        {% set target_date_local = now_local.date() %}
+        {% set tz_offset = now_local.utcoffset() %}
 
-        {# Determine today's date and UTC offset in target timezone.
-           Use localize+astimezone only to probe the offset, not for final values. #}
-        {% set probe = utc_tz.localize(now_utc).astimezone(target_tz) %}
-        {% set target_date_local = probe.date() %}
-        {% set tz_offset = probe.utcoffset() %}
-        {% set now_local = probe %}
+        {# Keep a naive UTC datetime for final deadline comparison #}
+        {% set now_utc = datetime.datetime.utcnow() %}
 
         {# Build all datetimes as naive local, then convert to naive UTC
            by subtracting the timezone offset. This avoids tz-aware comparison. #}
@@ -103,6 +99,8 @@
             - tz_offset
         ) %}
 
+        {# Compare naive UTC datetimes #}
+        {% set deadline_passed = now_utc > sla_deadline_utc %}
     {% else %}
         {# Standard dbt-core path using pytz.localize() #}
         {% set utc_tz = pytz.timezone("UTC") %}
@@ -132,6 +130,7 @@
         ) %}
         {% set sla_deadline_utc = sla_deadline_local.astimezone(utc_tz) %}
 
+        {% set deadline_passed = now_utc > sla_deadline_utc %}
     {% endif %}
 
     {# Format for SQL #}
@@ -147,6 +146,7 @@
                 "target_date": target_date_str,
                 "target_date_start_utc": day_start_utc_str,
                 "target_date_end_utc": day_end_utc_str,
+                "deadline_passed": deadline_passed,
                 "day_of_week": now_local.strftime("%A"),
                 "day_of_month": now_local.day,
             }