Skip to content

Ele 4592 fix tests for athena#820

Merged
arbiv merged 4 commits into
masterfrom
ele-4592-fix-tests-for-athena
Jun 12, 2025
Merged

Ele 4592 fix tests for athena#820
arbiv merged 4 commits into
masterfrom
ele-4592-fix-tests-for-athena

Conversation

@arbiv
Copy link
Copy Markdown
Contributor

@arbiv arbiv commented Jun 11, 2025

Summary by CodeRabbit

  • Chores
    • Updated installation logic for the Athena dbt adapter to apply version constraints based on the selected dbt version. This ensures more accurate package installation during workflow runs.

@arbiv arbiv requested a review from haritamar June 11, 2025 06:58
@linear
Copy link
Copy Markdown

linear Bot commented Jun 11, 2025

@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@arbiv arbiv had a problem deploying to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Error
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:58 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

👋 @arbiv
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 06:59 — with GitHub Actions Inactive
@arbiv arbiv had a problem deploying to elementary_test_env June 11, 2025 07:00 — with GitHub Actions Failure
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv had a problem deploying to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Error
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:46 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 09:54 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 10:52 — with GitHub Actions Inactive
- Use latest dbt-athena-community when running with latest dbt versions
- Fix conflicting version constraints that caused pip install failures
- Maintain compatibility for dbt 1.8.0 with athena-community>=1.7.0,<1.9.0
- Separate athena version logic from general dbt version constraint logic

Co-Authored-By: Yosef Arbiv <yosef.arbiv@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 11, 2025

Walkthrough

The update modifies the GitHub Actions workflow to change the version specifier for installing the dbt adapter package across multiple warehouse types. The version constraint operator was changed from <= to ~= for non-latest dbt versions, affecting the installation command logic for all supported warehouses including special cases.

Changes

File(s) Change Summary
.github/workflows/test-warehouse.yml Changed dbt adapter package version constraint from <= to ~= for non-latest dbt versions during installation.

Poem

In the code where versions play,
The adapters find a newer way.
From less-than-equal to tilde’s grace,
Each package fits its proper place.
A rabbit hops through YAML’s maze,
With versions dancing in new ways! 🐇🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73f56da and ce0a90d.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test-warehouse.yml

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdb78ff and 73f56da.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml (1 hunks)

Comment thread .github/workflows/test-warehouse.yml Outdated
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:29 — with GitHub Actions Inactive
@arbiv arbiv temporarily deployed to elementary_test_env June 11, 2025 13:32 — with GitHub Actions Inactive
@arbiv arbiv merged commit 4080642 into master Jun 12, 2025
15 checks passed
@arbiv arbiv deleted the ele-4592-fix-tests-for-athena branch June 12, 2025 08:06
@coderabbitai coderabbitai Bot mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants