Skip to content

Make config compliant with Fusion#842

Closed
b-per wants to merge 2 commits into
elementary-data:masterfrom
b-per:update-config-strict-parsing
Closed

Make config compliant with Fusion#842
b-per wants to merge 2 commits into
elementary-data:masterfrom
b-per:update-config-strict-parsing

Conversation

@b-per
Copy link
Copy Markdown

@b-per b-per commented Aug 14, 2025

Today, Fusion raises warnings when parsing finds incorrect config.
Soon, those warnings will become errors.

This PR updates the config that is raising warnings-soon-to-be-errors in Fusion

  • in yaml, meta needs to go under config
    • it should still be accessible via node.meta but also via node.config.meta
  • config blocks and config in YAML only accept out of the box configs. Custom configs need to move under meta that is itself under config

The following changes remove parsing warnings but I haven't run integration tests on Core or Fusion to check if there is any impact.

@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@b-per b-per had a problem deploying to elementary_test_env August 14, 2025 10:14 — with GitHub Actions Failure
@github-actions
Copy link
Copy Markdown
Contributor

👋 @b-per
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 14, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@haritamar haritamar closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants