Add integration tests for data_freshness_sla and volume_threshold

[devin-ai-integration]

Add integration tests for data_freshness_sla and volume_threshold

Summary

Adds integration test coverage for the two new Elementary tests introduced in this PR branch: data_freshness_sla and volume_threshold.

test_data_freshness_sla.py (6 tests):

• Fresh data passes, stale data fails, no-data fails
• Deadline-not-yet-passed does not fail
• where_expression filtering
• Non-UTC timezone handling

test_volume_threshold.py (8 tests):

• Stable volume passes
• Large spike/drop triggers failure
• direction parameter (spike-only, drop-only)
• min_row_count skips small baselines
• Custom warn/error thresholds
• where_expression filtering

Both files follow existing integration test conventions (pytest fixtures, DbtProject.test(), generate_dates, etc.).

Review & Testing Checklist for Human

• Time-sensitive flakiness: test_stale_data_fails uses sla_time: "00:01" UTC — will break if CI runs between 00:00–00:01 UTC. test_deadline_not_passed_does_not_fail uses Etc/GMT-14 to push deadline into the future — verify this works with pytz in the SLA macro.
• test_custom_thresholds warn assertion: Asserts status == "warn" for an 8% change. This depends on the fail_calc='max(severity_level)' / warn_if='>=1' / error_if='>=2' config in the macro — verify this produces a "warn" (not "fail" or "pass") in elementary_test_results.
• Tests were not executed against any warehouse — they were written by reading existing test patterns and the macro SQL. Run at least the Postgres suite (pytest test_data_freshness_sla.py test_volume_threshold.py -vvv --target postgres) to validate.
• Multi-step tests reuse test_id without re-seeding: In test_with_where_expression and test_custom_thresholds, the second assertion relies on data persisting from the first seed. Verify this works with the test infrastructure.
• Missing coverage: day_of_week/day_of_month scheduling for data_freshness_sla is not tested. Consider if this is acceptable or needs follow-up.

Notes

• Requested by: @haritamar
• Devin Session

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4230a797-7c8d-47b2-a6fe-aefe4f566364

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch devin/1773323122-add-integration-tests-sla-volume-threshold

📝 Coding Plan for PR comments

• Generate coding plan

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}