fix: include fabricspark in delta file_format config for integration tests#967
fix: include fabricspark in delta file_format config for integration tests#967
Conversation
…tests The integration_tests dbt_project.yml only set file_format=delta for target.type == 'spark'. Fabricspark also uses Delta Lake (Fabric Lakehouse), so it needs the same config. Relates to ELE-5296 Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @devin-ai-integration[bot] |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated dbt project configuration in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Comment |
fix: include fabricspark in delta file_format config for integration tests
Summary
The integration tests
dbt_project.ymlsetsfile_format: deltaonly whentarget.type == 'spark'. Sincedbt-fabricsparkalso uses Delta Lake (Fabric Lakehouse), it needs the same config. This was missed in the ELE-5295 fabricspark adapter PR (#964).Both occurrences (under
elementary_testsandelementarymodel configs) are updated fromtarget.type == 'spark'totarget.type in ['spark', 'fabricspark'].Review & Testing Checklist for Human
fabricsparkis the correcttarget.typestring used bydbt-fabricspark(consistent with the macros added in feat: add dbt-fabricspark adapter support (ELE-5295) #964)Notes
Companion fix to elementary CLI PR #2142 (merged), which made the same change in
elementary/monitor/dbt_project/dbt_project.yml.Link to Devin session: https://app.devin.ai/sessions/4eb7943788c44f04ab05ace61f50d05b
Requested by: @haritamar
Summary by CodeRabbit