Skip to content

fix: allow _with_context tests to collect sample rows #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joostboon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: allow _with_context tests to collect sample rows #981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e3c6b1
fix: allow _with_context tests to collect sample rows
joostboon Apr 7, 2026
37988b0
fix: use get_elementary_test_type to gate early return in test materi…
joostboon Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions macros/edr/materializations/test/test.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,14 @@

{% set test_namespace = model.get("test_metadata", {}).get("namespace") %}
{% if test_namespace == "elementary" %}
{# Custom test materialization is needed only for non-elementary tests #}
{% do return(materialization_macro()) %}
{% set short_name = model.get("test_metadata", {}).get("name", "") | lower %}
{% set elementary_test_type = elementary.get_elementary_test_type(
{"short_name": short_name, "test_namespace": "elementary"}
) %}
{% if elementary_test_type %}
{# Anomaly detection and schema change tests handle their own result row collection #}
{% do return(materialization_macro()) %}
{% endif %}
{% endif %}

{% set flattened_test = elementary.flatten_test(model) %}
Expand Down
Loading