Skip to content

Commit 0e96bc3

Browse files
Gate get_test_rows_sample on disable_samples in _process_raw_test_results
When disable_samples=true, ensure no sample data leaks via the legacy elementary_test_results.result_rows JSON column. Previously only the test_result_rows table query was skipped; get_test_rows_sample would still return data from the legacy column. Thread disable_samples into _process_raw_test_results and gate the entire get_test_rows_sample call so disable_samples=true means no sample data at all. Co-Authored-By: mika@elementary-data.com <mika.kerman@gmail.com>
1 parent b1dbb25 commit 0e96bc3

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

elementary/monitor/dbt_project/macros/get_test_results.sql

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
Called by both default__ and fabric__ dispatches to avoid duplicating the
88
Jinja processing loop.
99
#}
10-
{%- macro _process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status) -%}
10+
{%- macro _process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status, disable_samples = false) -%}
1111
{% set test_results = [] %}
1212
{% set tests = elementary.agate_to_dicts(test_results_agate) %}
1313

@@ -26,7 +26,7 @@
2626
{% set test_params = fromjson(test.test_params) %}
2727
{% set status = test.status | lower %}
2828

29-
{%- if (test_type == 'dbt_test' and status in ['fail', 'warn']) or (test_type != 'dbt_test' and status in elementary_tests_allowlist_status) -%}
29+
{%- if not disable_samples and ((test_type == 'dbt_test' and status in ['fail', 'warn']) or (test_type != 'dbt_test' and status in elementary_tests_allowlist_status)) -%}
3030
{% set test_rows_sample = elementary_cli.get_test_rows_sample(test.result_rows, test_result_rows_agate.get(test.id)) %}
3131
{%- endif -%}
3232
{% else %}
@@ -120,7 +120,7 @@
120120
{% do elementary.fully_drop_relation(ordered_test_results_relation) %}
121121
{% endif %}
122122

123-
{% do return(elementary_cli._process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status)) %}
123+
{% do return(elementary_cli._process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status, disable_samples)) %}
124124
{%- endmacro -%}
125125

126126
{%- macro fabric__get_test_results(days_back = 7, invocations_per_test = 720, disable_passed_test_metrics = false, disable_samples = false) -%}
@@ -179,7 +179,7 @@
179179
{% do elementary.fully_drop_relation(base_relation) %}
180180
{% do elementary.fully_drop_relation(ordered_relation) %}
181181

182-
{% do return(elementary_cli._process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status)) %}
182+
{% do return(elementary_cli._process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status, disable_samples)) %}
183183
{%- endmacro -%}
184184

185185
{%- macro clickhouse__get_test_results(days_back = 7, invocations_per_test = 720, disable_passed_test_metrics = false, disable_samples = false) -%}
@@ -319,5 +319,5 @@
319319
{% do elementary.fully_drop_relation(ordered_test_results_relation) %}
320320
{% endif %}
321321

322-
{% do return(elementary_cli._process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status)) %}
322+
{% do return(elementary_cli._process_raw_test_results(test_results_agate, test_result_rows_agate, elementary_tests_allowlist_status, disable_samples)) %}
323323
{%- endmacro -%}

0 commit comments

Comments
 (0)