Skip to content

Commit 42b24da

Browse files
fix: update test_alerts_fetcher positional indices for --log-format prepend
The refactor to always prepend --log-format json to dbt commands shifted all positional args by 2. Update hardcoded indices in test assertions. Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
1 parent 24e593c commit 42b24da

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

tests/unit/monitor/fetchers/alerts/test_alerts_fetcher.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,11 @@ def test_update_sent_alerts(
3333
calls_args = mock_subprocess_run.call_args_list
3434
for call_args in calls_args:
3535
# Test that update_sent_alerts has been called with alert_ids as arguments.
36-
assert call_args[0][0][1] == "run"
37-
assert call_args[0][0][2] == "-s"
38-
assert call_args[0][0][3] == "elementary_cli.update_alerts.update_sent_alerts"
39-
dbt_run_params = json.loads(call_args[0][0][9])
36+
# Indices account for --log-format json being prepended to all dbt commands.
37+
assert call_args[0][0][3] == "run"
38+
assert call_args[0][0][4] == "-s"
39+
assert call_args[0][0][5] == "elementary_cli.update_alerts.update_sent_alerts"
40+
dbt_run_params = json.loads(call_args[0][0][11])
4041
assert "alert_ids" in dbt_run_params
4142
assert "sent_at" in dbt_run_params
4243

@@ -57,12 +58,13 @@ def test_skip_alerts(mock_subprocess_run, alerts_fetcher_mock: MockAlertsFetcher
5758
calls_args = mock_subprocess_run.call_args_list
5859
for call_args in calls_args:
5960
# Test that update_skipped_alerts has been called with alert_ids as arguments.
60-
assert call_args[0][0][1] == "run"
61-
assert call_args[0][0][2] == "-s"
61+
# Indices account for --log-format json being prepended to all dbt commands.
62+
assert call_args[0][0][3] == "run"
63+
assert call_args[0][0][4] == "-s"
6264
assert (
63-
call_args[0][0][3] == "elementary_cli.update_alerts.update_skipped_alerts"
65+
call_args[0][0][5] == "elementary_cli.update_alerts.update_skipped_alerts"
6466
)
65-
dbt_run_params = json.loads(call_args[0][0][9])
67+
dbt_run_params = json.loads(call_args[0][0][11])
6668
assert "alert_ids" in dbt_run_params
6769

6870

0 commit comments

Comments
 (0)