Skip to content

Commit 45831f3

Browse files
Run CLI tests on all warehouses instead of just Postgres (#2094)
* Run CLI tests on all warehouses instead of just Postgres - Add pull_request_target trigger to test-all-warehouses.yml - Add workflow_call trigger for reusability - Remove dbt 1.8.0 from matrix, run only on latest version - Update elementary-ref to use PR head SHA for pull_request_target events - Skip Slack notifications for PR failures to avoid spam - Delete test-main-warehouse.yml (superseded by test-all-warehouses.yml) Resolves ELE-5218 Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Remove workflow_call trigger (not used by any other workflow) Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
1 parent 8df8ccd commit 45831f3

2 files changed

Lines changed: 10 additions & 20 deletions

File tree

.github/workflows/test-all-warehouses.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
name: Test all warehouse platforms
22
on:
3+
pull_request_target:
4+
branches: ["master"]
5+
paths:
6+
- elementary/**
7+
- .github/**
8+
- pyproject.toml
39
workflow_dispatch:
410
inputs:
511
elementary-ref:
@@ -25,13 +31,13 @@ jobs:
2531
strategy:
2632
fail-fast: false
2733
matrix:
28-
dbt-version: ${{ inputs.dbt-version && fromJSON(format('["{0}"]', inputs.dbt-version)) || fromJSON('["1.8.0", null]') }}
34+
dbt-version: ${{ inputs.dbt-version && fromJSON(format('["{0}"]', inputs.dbt-version)) || fromJSON('[null]') }}
2935
warehouse-type:
3036
[postgres, snowflake, bigquery, redshift, databricks_catalog, athena]
3137
uses: ./.github/workflows/test-warehouse.yml
3238
with:
3339
warehouse-type: ${{ matrix.warehouse-type }}
34-
elementary-ref: ${{ inputs.elementary-ref }}
40+
elementary-ref: ${{ inputs.elementary-ref || (github.event_name == 'pull_request_target' && github.event.pull_request.head.sha) || '' }}
3541
dbt-data-reliability-ref: ${{ inputs.dbt-data-reliability-ref }}
3642
dbt-version: ${{ matrix.dbt-version }}
3743
generate-data: ${{ inputs.generate-data || false }}
@@ -45,7 +51,8 @@ jobs:
4551
always() &&
4652
! cancelled() &&
4753
! contains(needs.test.result, 'success') &&
48-
! contains(needs.test.result, 'cancelled')
54+
! contains(needs.test.result, 'cancelled') &&
55+
github.event_name != 'pull_request_target'
4956
uses: ./.github/workflows/notify_slack.yml
5057
with:
5158
result: "failure"

.github/workflows/test-main-warehouse.yml

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)