Skip to content

Commit 5a4a5d2

Browse files
refactor: move clean_elementary_temp_tables to dbt_project.yml per review feedback
- clean_elementary_temp_tables: false now set in dbt_project.yml (applies to all steps) - disable_dbt_artifacts_autoupload: true remains on CLI for dbt test step only (dbt run still needs to upload artifacts) Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
1 parent 5751281 commit 5a4a5d2

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/test-warehouse.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ jobs:
192192
working-directory: ${{ env.E2E_DBT_PROJECT_DIR }}
193193
continue-on-error: true
194194
run: |
195-
dbt test --target "${{ inputs.warehouse-type }}" --vars '{disable_dbt_artifacts_autoupload: true, clean_elementary_temp_tables: false}'
195+
dbt test --target "${{ inputs.warehouse-type }}" --vars '{disable_dbt_artifacts_autoupload: true}'
196196
197197
- name: Run help
198198
run: edr --help

tests/e2e_dbt_project/dbt_project.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ vars:
2020
days_back: 30
2121
debug_logs: "{{ env_var('DBT_EDR_DEBUG', False) }}"
2222
custom_run_started_at: "{{ modules.datetime.datetime.utcfromtimestamp(0) }}"
23+
clean_elementary_temp_tables: false
2324

2425
seeds:
2526
+schema: test_seeds

0 commit comments

Comments
 (0)