Skip to content

Commit 5c6b660

Browse files
MikaKermanMikaKerman
committed
Update alert message tests to include subscriber information
* Added `subscribers` parameter to various alert message test cases to ensure proper handling of subscriber data. * Introduced new fixture files for block kit and adaptive card formats reflecting subscriber details. * Updated existing fixture files to replace placeholder text for subscribers with actual subscriber information. * Enhanced `MessageBuilderConfig` integration to conditionally display subscriber information in alert messages.
1 parent 943921d commit 5c6b660

52 files changed

Lines changed: 794 additions & 484 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-False_test-warnings-True_test-errors-True_link-False_env-False.json renamed to tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-False_test-warnings-True_test-errors-True_link-False_env-False_subscribers-True.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@
4141
},
4242
{
4343
"type": "TextBlock",
44-
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
44+
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_2** - Owner: owner1 - Subscriber: subscriber1",
4545
"wrap": true
4646
},
4747
{
4848
"type": "TextBlock",
49-
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
49+
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
5050
"wrap": true
5151
},
5252
{
@@ -56,12 +56,12 @@
5656
},
5757
{
5858
"type": "TextBlock",
59-
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
59+
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_5** - Owner: owner1 - Subscriber: subscriber1",
6060
"wrap": true
6161
},
6262
{
6363
"type": "TextBlock",
64-
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
64+
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
6565
"wrap": true
6666
},
6767
{
@@ -71,12 +71,12 @@
7171
},
7272
{
7373
"type": "TextBlock",
74-
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
74+
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_8** - Owner: owner1 - Subscriber: subscriber1",
7575
"wrap": true
7676
},
7777
{
7878
"type": "TextBlock",
79-
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2",
79+
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
8080
"wrap": true
8181
},
8282
{
@@ -102,12 +102,12 @@
102102
},
103103
{
104104
"type": "TextBlock",
105-
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
105+
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1 - Subscriber: subscriber1",
106106
"wrap": true
107107
},
108108
{
109109
"type": "TextBlock",
110-
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
110+
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
111111
"wrap": true
112112
},
113113
{
@@ -117,12 +117,12 @@
117117
},
118118
{
119119
"type": "TextBlock",
120-
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
120+
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1 - Subscriber: subscriber1",
121121
"wrap": true
122122
},
123123
{
124124
"type": "TextBlock",
125-
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
125+
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
126126
"wrap": true
127127
},
128128
{
@@ -132,12 +132,12 @@
132132
},
133133
{
134134
"type": "TextBlock",
135-
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
135+
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1 - Subscriber: subscriber1",
136136
"wrap": true
137137
},
138138
{
139139
"type": "TextBlock",
140-
"text": "\u2757 **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2",
140+
"text": "\u2757 **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
141141
"wrap": true
142142
},
143143
{

tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-True_test-warnings-False_test-errors-False_link-False_env-False.json renamed to tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-True_test-warnings-False_test-errors-False_link-False_env-False_subscribers-True.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@
4141
},
4242
{
4343
"type": "TextBlock",
44-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
44+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owner: owner1 - Subscriber: subscriber1",
4545
"wrap": true
4646
},
4747
{
4848
"type": "TextBlock",
49-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
49+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
5050
"wrap": true
5151
},
5252
{
@@ -56,12 +56,12 @@
5656
},
5757
{
5858
"type": "TextBlock",
59-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
59+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owner: owner1 - Subscriber: subscriber1",
6060
"wrap": true
6161
},
6262
{
6363
"type": "TextBlock",
64-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
64+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
6565
"wrap": true
6666
},
6767
{
@@ -71,12 +71,12 @@
7171
},
7272
{
7373
"type": "TextBlock",
74-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
74+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owner: owner1 - Subscriber: subscriber1",
7575
"wrap": true
7676
},
7777
{
7878
"type": "TextBlock",
79-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2",
79+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
8080
"wrap": true
8181
},
8282
{

tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-True_test-warnings-False_test-errors-True_link-False_env-False.json renamed to tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-True_test-warnings-False_test-errors-True_link-False_env-False_subscribers-True.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@
4141
},
4242
{
4343
"type": "TextBlock",
44-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
44+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owner: owner1 - Subscriber: subscriber1",
4545
"wrap": true
4646
},
4747
{
4848
"type": "TextBlock",
49-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
49+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
5050
"wrap": true
5151
},
5252
{
@@ -56,12 +56,12 @@
5656
},
5757
{
5858
"type": "TextBlock",
59-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
59+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owner: owner1 - Subscriber: subscriber1",
6060
"wrap": true
6161
},
6262
{
6363
"type": "TextBlock",
64-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
64+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
6565
"wrap": true
6666
},
6767
{
@@ -71,12 +71,12 @@
7171
},
7272
{
7373
"type": "TextBlock",
74-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
74+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owner: owner1 - Subscriber: subscriber1",
7575
"wrap": true
7676
},
7777
{
7878
"type": "TextBlock",
79-
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2",
79+
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
8080
"wrap": true
8181
},
8282
{
@@ -102,12 +102,12 @@
102102
},
103103
{
104104
"type": "TextBlock",
105-
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
105+
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1 - Subscriber: subscriber1",
106106
"wrap": true
107107
},
108108
{
109109
"type": "TextBlock",
110-
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
110+
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
111111
"wrap": true
112112
},
113113
{
@@ -117,12 +117,12 @@
117117
},
118118
{
119119
"type": "TextBlock",
120-
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
120+
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1 - Subscriber: subscriber1",
121121
"wrap": true
122122
},
123123
{
124124
"type": "TextBlock",
125-
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
125+
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
126126
"wrap": true
127127
},
128128
{
@@ -132,12 +132,12 @@
132132
},
133133
{
134134
"type": "TextBlock",
135-
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
135+
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1 - Subscriber: subscriber1",
136136
"wrap": true
137137
},
138138
{
139139
"type": "TextBlock",
140-
"text": "\u2757 **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2",
140+
"text": "\u2757 **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
141141
"wrap": true
142142
},
143143
{

tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-True_test-warnings-True_test-errors-True_link-True_env-True.json renamed to tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-False_test-failures-True_test-warnings-True_test-errors-True_link-True_env-True_subscribers-False.json

File renamed without changes.

tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-True_test-failures-False_test-warnings-False_test-errors-True_link-False_env-False.json renamed to tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-True_test-failures-False_test-warnings-False_test-errors-True_link-False_env-False_subscribers-True.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@
4141
},
4242
{
4343
"type": "TextBlock",
44-
"text": "\u274c **dbt failed to build table \"test_model\"** - Owner: owner1",
44+
"text": "\u274c **dbt failed to build table \"test_model\"** - Owner: owner1 - Subscriber: subscriber1",
4545
"wrap": true
4646
},
4747
{
4848
"type": "TextBlock",
49-
"text": "\u274c **dbt failed to build table \"test_model\"** - Owners: owner1, owner2",
49+
"text": "\u274c **dbt failed to build table \"test_model\"** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
5050
"wrap": true
5151
},
5252
{
@@ -56,12 +56,12 @@
5656
},
5757
{
5858
"type": "TextBlock",
59-
"text": "\u274c **dbt failed to build table \"test_model\"** - Owner: owner1",
59+
"text": "\u274c **dbt failed to build table \"test_model\"** - Owner: owner1 - Subscriber: subscriber1",
6060
"wrap": true
6161
},
6262
{
6363
"type": "TextBlock",
64-
"text": "\u274c **dbt failed to build table \"test_model\"** - Owners: owner1, owner2",
64+
"text": "\u274c **dbt failed to build table \"test_model\"** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
6565
"wrap": true
6666
},
6767
{
@@ -71,12 +71,12 @@
7171
},
7272
{
7373
"type": "TextBlock",
74-
"text": "\u274c **dbt failed to build table \"test_model\"** - Owner: owner1",
74+
"text": "\u274c **dbt failed to build table \"test_model\"** - Owner: owner1 - Subscriber: subscriber1",
7575
"wrap": true
7676
},
7777
{
7878
"type": "TextBlock",
79-
"text": "\u274c **dbt failed to build table \"test_model\"** - Owners: owner1, owner2",
79+
"text": "\u274c **dbt failed to build table \"test_model\"** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
8080
"wrap": true
8181
},
8282
{
@@ -102,12 +102,12 @@
102102
},
103103
{
104104
"type": "TextBlock",
105-
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
105+
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1 - Subscriber: subscriber1",
106106
"wrap": true
107107
},
108108
{
109109
"type": "TextBlock",
110-
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
110+
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
111111
"wrap": true
112112
},
113113
{
@@ -117,12 +117,12 @@
117117
},
118118
{
119119
"type": "TextBlock",
120-
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
120+
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1 - Subscriber: subscriber1",
121121
"wrap": true
122122
},
123123
{
124124
"type": "TextBlock",
125-
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
125+
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
126126
"wrap": true
127127
},
128128
{
@@ -132,12 +132,12 @@
132132
},
133133
{
134134
"type": "TextBlock",
135-
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
135+
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1 - Subscriber: subscriber1",
136136
"wrap": true
137137
},
138138
{
139139
"type": "TextBlock",
140-
"text": "\u2757 **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2",
140+
"text": "\u2757 **\"test_short_name\" test failed on test_table_9** - Owners: owner1, owner2 - Subscribers: subscriber1, subscriber2",
141141
"wrap": true
142142
},
143143
{

tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-True_test-failures-False_test-warnings-True_test-errors-False_link-True_env-False.json renamed to tests/unit/alerts/alert_messages/fixtures/adaptive_card/alerts_group_model-errors-True_test-failures-False_test-warnings-True_test-errors-False_link-True_env-False_subscribers-False.json

File renamed without changes.

0 commit comments

Comments
 (0)