Skip to content

Commit 7328c48

Browse files
fix: remove continue-on-error for Dremio edr steps (ref() override now on master)
Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
1 parent e450aa3 commit 7328c48

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

.github/workflows/test-warehouse.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,6 @@ jobs:
304304
run: edr --help
305305

306306
- name: Run monitor
307-
# dbt-dremio pulls dbt-core 1.11 which breaks ref('package', 'model') syntax
308-
continue-on-error: ${{ inputs.warehouse-type == 'dremio' }}
309307
env:
310308
SLACK_WEBHOOK: ${{ secrets.CI_SLACK_WEBHOOK }}
311309
run: >
@@ -317,14 +315,12 @@ jobs:
317315
--slack-webhook "$SLACK_WEBHOOK"
318316
319317
- name: Validate alerts statuses were updated
320-
continue-on-error: ${{ inputs.warehouse-type == 'dremio' }}
321318
working-directory: ${{ env.CLI_INTERNAL_DBT_PKG_DIR }}
322319
run: |
323320
dbt deps
324321
dbt run-operation validate_alert_statuses_are_updated -t "${{ inputs.warehouse-type }}"
325322
326323
- name: Run report
327-
continue-on-error: ${{ inputs.warehouse-type == 'dremio' }}
328324
run: >
329325
edr monitor report
330326
-t "${{ inputs.warehouse-type }}"
@@ -349,7 +345,6 @@ jobs:
349345
run: echo "$GCS_KEYFILE" | base64 -d > /tmp/gcs_keyfile.json
350346

351347
- name: Run send report
352-
continue-on-error: ${{ inputs.warehouse-type == 'dremio' }}
353348
env:
354349
SLACK_TOKEN: ${{ secrets.CI_SLACK_TOKEN }}
355350
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -387,7 +382,6 @@ jobs:
387382
path: elementary/edr_target/edr.log
388383

389384
- name: Run Python package e2e tests
390-
continue-on-error: ${{ inputs.warehouse-type == 'dremio' }}
391385
run: pytest -vv tests/e2e --warehouse-type ${{ inputs.warehouse-type }}
392386

393387
- name: Drop test schemas

0 commit comments

Comments
 (0)