Skip to content

Commit 80bd692

Browse files
committed
fix: add explicit AS aliases to all columns in get_tests & populate_test_alerts_query to support ClickHouse < 24.3
1 parent 5d08a08 commit 80bd692

2 files changed

Lines changed: 28 additions & 28 deletions

File tree

elementary/monitor/dbt_project/macros/alerts/population/test_alerts.sql

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
)
127127

128128
select distinct
129-
failed_tests.alert_id,
129+
failed_tests.alert_id as alert_id,
130130
{# Generate elementary unique id which is used to identify between tests, and set it as alert_class_id #}
131131
{{ dbt.concat(["coalesce(failed_tests.test_unique_id, 'None')", "'.'", "coalesce(failed_tests.column_name, 'None')", "'.'", "coalesce(failed_tests.sub_type, 'None')"]) }} as alert_class_id,
132132
case
@@ -135,39 +135,39 @@
135135
when tests.short_name = 'dimension_anomalies' then failed_tests.test_unique_id
136136
else {{ dbt.concat(["coalesce(failed_tests.test_unique_id, 'None')", "'.'", "coalesce(failed_tests.column_name, 'None')", "'.'", "coalesce(failed_tests.sub_type, 'None')"]) }}
137137
end as elementary_unique_id,
138-
failed_tests.data_issue_id,
139-
failed_tests.test_execution_id,
140-
failed_tests.test_unique_id,
141-
failed_tests.model_unique_id,
138+
failed_tests.data_issue_id as data_issue_id,
139+
failed_tests.test_execution_id as test_execution_id,
140+
failed_tests.test_unique_id as test_unique_id,
141+
failed_tests.model_unique_id as model_unique_id,
142142
{# Explicit aliases for columns that exist in both failed_tests and tests tables to avoid ClickHouse column name ambiguity #}
143143
failed_tests.database_name as database_name,
144-
failed_tests.detected_at,
144+
failed_tests.detected_at as detected_at,
145145
{{ elementary.edr_current_timestamp() }} as created_at,
146146
failed_tests.schema_name as schema_name,
147-
failed_tests.table_name,
148-
failed_tests.column_name,
147+
failed_tests.table_name as table_name,
148+
failed_tests.column_name as column_name,
149149
failed_tests.test_type as alert_type,
150-
failed_tests.sub_type,
150+
failed_tests.sub_type as sub_type,
151151
failed_tests.test_results_description as alert_description,
152-
failed_tests.owners,
152+
failed_tests.owners as owners,
153153
failed_tests.tags as tags,
154154
failed_tests.test_results_query as alert_results_query,
155-
failed_tests.other,
156-
failed_tests.test_name,
157-
failed_tests.test_short_name,
155+
failed_tests.other as other,
156+
failed_tests.test_name as test_name,
157+
failed_tests.test_short_name as test_short_name,
158158
failed_tests.test_params as test_params,
159159
failed_tests.severity as severity,
160160
failed_tests.status as status,
161161
failed_tests.result_rows as result_rows,
162162
tests.meta as test_meta,
163163
tests.description as test_description,
164164
artifacts_meta.meta as model_meta,
165-
invocations.job_id,
166-
invocations.job_name,
167-
invocations.job_run_id,
168-
invocations.job_url,
169-
invocations.job_run_url,
170-
invocations.orchestrator
165+
invocations.job_id as job_id,
166+
invocations.job_name as job_name,
167+
invocations.job_run_id as job_run_id,
168+
invocations.job_url as job_url,
169+
invocations.job_run_url as job_run_url,
170+
invocations.orchestrator as orchestrator
171171
from failed_tests
172172
left join tests on failed_tests.test_unique_id = tests.unique_id
173173
left join artifacts_meta on failed_tests.model_unique_id = artifacts_meta.unique_id

elementary/monitor/dbt_project/macros/get_tests.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,22 +65,22 @@
6565
select
6666
tests.unique_id as unique_id,
6767
tests.parent_model_unique_id as model_unique_id,
68-
tests.database_name,
69-
tests.schema_name,
68+
tests.database_name as database_name,
69+
tests.schema_name as schema_name,
7070
nodes.name as model_name,
7171
tests.test_column_name as column_name,
7272
tests.name as name,
73-
tests.description,
74-
tests.package_name,
75-
tests.original_path,
76-
tests.test_params,
73+
tests.description as description,
74+
tests.package_name as package_name,
75+
tests.original_path as original_path,
76+
tests.test_params as test_params,
7777
tests.meta as meta,
7878
nodes.meta as model_meta,
79-
tests.tags,
79+
tests.tags as tags,
8080
nodes.tags as model_tags,
8181
tests.type as type,
82-
last_test_results.test_type,
83-
last_test_results.test_sub_type,
82+
last_test_results.test_type as test_type,
83+
last_test_results.test_sub_type as test_sub_type,
8484
test_results_times.first_detected_at as created_at,
8585
last_test_results.detected_at as latest_run_time,
8686
last_test_results.status as latest_run_status

0 commit comments

Comments
 (0)