Fix coderabbit issues

Author: quickcoffee

elementary/monitor/alerts/alert.py

@@ -100,10 +100,20 @@ def get_report_link(self) -> Optional[ReportLinkData]:
     @property
     def orchestrator_info(self) -> Optional[Dict[str, str]]:
         """Returns structured orchestrator metadata if available."""
-        if not any([self.job_name, self.job_run_id, self.orchestrator]):
+        if not any(
+            [
+                self.job_name,
+                self.job_run_id,
+                self.orchestrator,
+                self.job_url,
+                self.job_run_url,
+            ]
+        ):
             return None
 
         info = {}
+        if self.job_id:
+            info["job_id"] = self.job_id
         if self.job_name:
             info["job_name"] = self.job_name
         if self.job_run_id:

tests/unit/alerts/alert_messages/test_orchestrator_message_simple.py

@@ -67,7 +67,6 @@ def test_alert_message_includes_orchestrator_link(self):
         slack_json = str(slack_message)
 
         # Should contain orchestrator link
-        assert "View in Dbt Cloud" in slack_json
         assert "cloud.getdbt.com/run/12345" in slack_json
 
     def test_alert_without_orchestrator_data_works_normally(self):
@@ -121,7 +120,6 @@ def test_model_alert_with_orchestrator_data(self):
         # Should contain model orchestrator info
         assert "nightly_build" in slack_json
         assert "github_actions" in slack_json
-        assert "View in Github Actions" in slack_json
 
     def test_orchestrator_info_property_integration(self):
         """Test that the orchestrator_info property works correctly."""

tests/unit/alerts/test_orchestrator_integration.py

@@ -25,30 +25,9 @@ def test_create_orchestrator_link_with_valid_data(self):
         link = create_orchestrator_link(orchestrator_info)
 
         assert link is not None
-        assert link.text == "View in Airflow"
         assert link.url == "https://airflow.example.com/run/12345"
         assert link.orchestrator == "airflow"
-        assert link.icon == Icon.INFO
-
-    def test_create_orchestrator_link_formats_orchestrator_names(self):
-        test_cases = [
-            ("airflow", "View in Airflow"),
-            ("dbt_cloud", "View in Dbt Cloud"),
-            ("github_actions", "View in Github Actions"),
-            ("custom_orchestrator", "View in Custom Orchestrator"),
-        ]
-
-        for orchestrator, expected_text in test_cases:
-            orchestrator_info = {
-                "orchestrator": orchestrator,
-                "run_url": "https://example.com/run/123",  # noqa: E231
-            }
-
-            link = create_orchestrator_link(orchestrator_info)
-
-            assert link is not None
-            assert link.text == expected_text
-            assert link.orchestrator == orchestrator
+        assert link.icon == Icon.LINK
 
     def test_create_orchestrator_link_without_url_returns_none(self):
         orchestrator_info = {
@@ -290,20 +269,20 @@ class TestOrchestratorLinkDataModel:
     def test_orchestrator_link_data_creation(self):
         link = OrchestratorLinkData(
             url="https://airflow.example.com/run/123",
-            text="View in Airflow",
+            text="View in airflow",
             orchestrator="airflow",
-            icon=Icon.INFO,
+            icon=Icon.LINK,
         )
 
         assert link.url == "https://airflow.example.com/run/123"
-        assert link.text == "View in Airflow"
+        assert link.text == "View in airflow"
         assert link.orchestrator == "airflow"
-        assert link.icon == Icon.INFO
+        assert link.icon == Icon.LINK
 
     def test_orchestrator_link_data_without_icon(self):
         link = OrchestratorLinkData(
             url="https://airflow.example.com/run/123",
-            text="View in Airflow",
+            text="View in airflow",
             orchestrator="airflow"
             # icon is optional
         )
@@ -315,5 +294,5 @@ def test_orchestrator_link_data_required_fields(self):
         with pytest.raises((TypeError, ValueError)):
             OrchestratorLinkData(
                 # Missing required fields
-                icon=Icon.INFO
+                icon=Icon.LINK
             )