fix: wire --config-dir CLI flag to Config initialization (#2121)

Fixes #2037

The --config-dir flag was parsed but never passed to Config(), which always
used the default ~/.edr. This wires the CLI argument through so the custom
config directory is actually used.

- Remove premature directory creation from Config._load_configuration that
  ran at import time (logo/upgrade) and created ~/.edr before CLI parsing
- Create config_dir in anonymous_tracking when writing user id file
- Add --config-dir to debug and dbt_init commands for consistency
- Use keyword args for Config() in report command for clarity

Co-authored-by: Itamar Hartstein <haritamar@gmail.com>

Author: The Mavik

elementary/config/config.py

@@ -224,8 +224,6 @@ def __init__(
         )
 
     def _load_configuration(self) -> dict:
-        if not os.path.exists(self.config_dir):
-            os.makedirs(self.config_dir)
         config_file_path = os.path.join(self.config_dir, self._CONFIG_FILE_NAME)
         if not os.path.exists(config_file_path):
             return {}

elementary/tracking/anonymous_tracking.py

@@ -24,7 +24,7 @@ def __init__(self, config: Config) -> None:
         self._run_id = str(uuid.uuid4())
 
         # Exceptions that occurred during the run of the CLI, but don't fail the entire run.
-        # We want to avoid sending an event for each one of these (as there might be many of them), so we will send
+        # We want to avoid sending an event for each one of these (as there might be many), so we will send
         # them as a part of the cli-end event.
         self.internal_exceptions: List[dict] = []
         self.internal_exceptions_count = 0
@@ -49,6 +49,7 @@ def _get_anonymous_user_id(self):
             pass
         user_id = str(uuid.uuid4())
         try:
+            user_id_path.parent.mkdir(parents=True, exist_ok=True)
             user_id_path.write_text(user_id)
         except OSError:
             pass
@@ -74,7 +75,7 @@ def _send_anonymous_event(
                 },
             )
         except Exception:
-            logger.debug("Unable to send tracking event.", exc_info=True)
+            logger.debug("Unable to send anonymous event.", exc_info=True)
 
     def record_internal_exception(self, exc: Exception):
         self.internal_exceptions_count += 1