Skip to content

Commit 9186609

Browse files
fix: address CodeRabbit review feedback
- Remove 'no transaction in progress' from Vertica transient patterns (it's a transaction-state notice, not a transient connection error) - Hardcode dbt-data-reliability-ref to 'vertica-compat' for the Vertica matrix entry until PR #963 merges into master Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
1 parent 919b8f6 commit 9186609

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/test-all-warehouses.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,9 @@ jobs:
108108
with:
109109
warehouse-type: ${{ matrix.warehouse-type }}
110110
elementary-ref: ${{ inputs.elementary-ref || ((github.event_name == 'pull_request_target' || github.event_name == 'pull_request') && github.event.pull_request.head.sha) || '' }}
111-
dbt-data-reliability-ref: ${{ inputs.dbt-data-reliability-ref }}
111+
# Vertica support lives on the vertica-compat branch of dbt-data-reliability
112+
# until PR #963 merges. After that, remove this override.
113+
dbt-data-reliability-ref: ${{ inputs.dbt-data-reliability-ref || (matrix.warehouse-type == 'vertica' && 'vertica-compat') || '' }}
112114
dbt-version: ${{ matrix.dbt-version }}
113115
generate-data: ${{ inputs.generate-data || false }}
114116
secrets: inherit

elementary/clients/dbt/transient_errors.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@
124124
"connection timed out",
125125
"could not connect to the server",
126126
"ssl syscall error",
127-
"no transaction in progress",
128127
),
129128
}
130129

0 commit comments

Comments
 (0)