fix: remove return from finally block to prevent exception swallowing (#2109)

The `get_log_path` function had a `return` statement inside a `finally`
block, which silently swallows any in-flight exceptions including
`BaseException` subclasses like `KeyboardInterrupt`.

Replace the `try/finally` with a proper `try/except` that catches the
expected `ValueError` (from `list.index()`) and `IndexError` (from
accessing the next argument), then move the directory creation and
return statement outside the exception handler.

Fixes #1731

Co-authored-by: Itamar Hartstein <haritamar@gmail.com>

Author: themavik

elementary/cli/cli.py

@@ -24,9 +24,10 @@ def get_log_path(ctx):
         ctx_args = ctx.args
         target_path_flag = "--target-path"
         target_path = ctx_args[ctx_args.index(target_path_flag) + 1]
-    finally:
-        os.makedirs(os.path.abspath(target_path), exist_ok=True)
-        return os.path.join(target_path, "edr.log")
+    except (ValueError, IndexError):
+        pass
+    os.makedirs(os.path.abspath(target_path), exist_ok=True)
+    return os.path.join(target_path, "edr.log")
 
 
 def get_quiet_logs(ctx):