Skip to content

Commit c8ed0b2

Browse files
committed
Revert "Include seeds without tests in filters"
This reverts commit 2d071b1.
1 parent 2d071b1 commit c8ed0b2

2 files changed

Lines changed: 4 additions & 18 deletions

File tree

elementary/monitor/api/filters/filters.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from elementary.monitor.api.models.schema import (
66
ModelRunsSchema,
77
NormalizedModelSchema,
8-
NormalizedSeedSchema,
98
NormalizedSourceSchema,
109
)
1110
from elementary.monitor.api.totals_schema import TotalsSchema
@@ -26,14 +25,11 @@ def get_filters(
2625
models: Dict[str, NormalizedModelSchema],
2726
sources: Dict[str, NormalizedSourceSchema],
2827
models_runs: List[ModelRunsSchema],
29-
seeds: Dict[str, NormalizedSeedSchema],
3028
) -> FiltersSchema:
3129
test_results_filters = self._get_test_filters(
32-
test_results_totals, models, sources, seeds
33-
)
34-
test_runs_filters = self._get_test_filters(
35-
test_runs_totals, models, sources, seeds
30+
test_results_totals, models, sources
3631
)
32+
test_runs_filters = self._get_test_filters(test_runs_totals, models, sources)
3733
model_runs_filters = self._get_model_runs_filters(models_runs)
3834
return FiltersSchema(
3935
test_results=test_results_filters,
@@ -46,7 +42,6 @@ def _get_test_filters(
4642
totals: Dict[str, TotalsSchema],
4743
models: Dict[str, NormalizedModelSchema],
4844
sources: Dict[str, NormalizedSourceSchema],
49-
seeds: Dict[str, NormalizedSeedSchema],
5045
) -> List[FilterSchema]:
5146
failures_filter = FilterSchema(name="failures", display_name="Failures")
5247
warnings_filter = FilterSchema(name="warnings", display_name="Warnings")
@@ -55,11 +50,7 @@ def _get_test_filters(
5550
no_tests_filter = FilterSchema(name="no_test", display_name="No Tests")
5651

5752
totals_models_ids = totals.keys()
58-
artifacts: List[ArtifactSchema] = [
59-
*models.values(),
60-
*sources.values(),
61-
*seeds.values(),
62-
]
53+
artifacts: List[ArtifactSchema] = [*models.values(), *sources.values()]
6354
for artifact in artifacts:
6455
if artifact.unique_id and artifact.unique_id not in totals_models_ids:
6556
no_tests_filter.add_model_unique_id(artifact.unique_id)

elementary/monitor/api/report/report.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,7 @@ def get_report_data(
161161
lineage_node_ids, exclude_elementary_models
162162
)
163163
filters = filters_api.get_filters(
164-
test_results_totals,
165-
test_runs_totals,
166-
models,
167-
sources,
168-
models_runs.runs,
169-
seeds,
164+
test_results_totals, test_runs_totals, models, sources, models_runs.runs
170165
)
171166

172167
serializable_groups = groups.dict()

0 commit comments

Comments
 (0)