Validate packages.yml uses proper version on release, fix bump-version to handle git hash conversion

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>

Author: devin-ai-integration[bot]

.github/workflows/bump-version.yml

@@ -61,6 +61,17 @@ jobs:
       - name: Bump version
         run: |
           sed -i 's/^version = "[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*"/version = "${{ inputs.cli-version }}"/' ./pyproject.toml
+      - name: Convert git hash reference to package version format (if needed)
+        run: |
+          PACKAGES_FILE="./elementary/monitor/dbt_project/packages.yml"
+          if grep -q 'git: https://github.com/elementary-data/dbt-data-reliability.git' "$PACKAGES_FILE"; then
+            echo "Found git hash reference in packages.yml, converting to package version format..."
+            # Replace the git+revision block with a package+version block using a placeholder version
+            sed -i '/- git: https:\/\/github.com\/elementary-data\/dbt-data-reliability.git/{N;s/- git: https:\/\/github.com\/elementary-data\/dbt-data-reliability.git\n    revision: [a-f0-9]*/- package: elementary-data\/elementary\n    version: 0.0.0/}' "$PACKAGES_FILE"
+            echo "Converted to package format with placeholder version."
+          else
+            echo "packages.yml already uses package version format."
+          fi
       - name: Bump version for package (using input)
         if: ${{ needs.validate-version.outputs.validated-dbt-package-version != ''}}
         run: |

.github/workflows/release.yml

@@ -9,7 +9,27 @@ env:
   IMAGE_NAME: ${{ github.repository }}
 
 jobs:
+  validate-packages-yml:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Elementary
+        uses: actions/checkout@v4
+
+      - name: Validate dbt-data-reliability is not a git hash reference
+        run: |
+          PACKAGES_FILE="./elementary/monitor/dbt_project/packages.yml"
+          if grep -q 'git: https://github.com/elementary-data/dbt-data-reliability.git' "$PACKAGES_FILE"; then
+            echo "::error::packages.yml contains a git hash reference for dbt-data-reliability. Releases must use a proper package version (e.g. 'package: elementary-data/elementary' with a 'version:' field). Please update packages.yml before releasing."
+            exit 1
+          fi
+          if ! grep -q 'package: elementary-data/elementary' "$PACKAGES_FILE"; then
+            echo "::error::packages.yml does not contain a proper package reference for elementary-data/elementary. Please update packages.yml before releasing."
+            exit 1
+          fi
+          echo "packages.yml validation passed - using proper package version reference."
+
   publish-to-pypi:
+    needs: validate-packages-yml
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Elementary
@@ -39,6 +59,7 @@ jobs:
           password: ${{ secrets.PYPI_PASS }}
 
   build-and-push-docker-image:
+    needs: validate-packages-yml
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -77,6 +98,7 @@ jobs:
           labels: ${{ steps.meta.outputs.labels }}
 
   merge-to-docs:
+    needs: validate-packages-yml
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4