code quality

Author: ofek1weiss

elementary/messages/formats/block_kit.py

@@ -1,4 +1,4 @@
-from typing import Any, Dict, List, Optional
+from typing import Any, Dict, List, Optional, Tuple
 
 from slack_sdk.models import blocks as slack_blocks
 
@@ -33,8 +33,8 @@ class BlockKitBuilder:
     _LONGEST_MARKDOWN_SUFFIX_LEN = 3  # length of markdown's code suffix (```)
 
     def __init__(self) -> None:
-        self._blocks: list[dict] = []
-        self._attachment_blocks: list[dict] = []
+        self._blocks: List[dict] = []
+        self._attachment_blocks: List[dict] = []
         self._is_divided = False
 
     def _format_icon(self, icon: Icon) -> str:
@@ -139,7 +139,7 @@ def _add_secondary_facts(self, facts: List[FactBlock]) -> None:
 
     def _add_fact_list_block(self, block: FactListBlock) -> None:
         remaining_facts = block.facts[:]
-        secondary_facts: list[FactBlock] = []
+        secondary_facts: List[FactBlock] = []
         while remaining_facts:
             current_fact = remaining_facts.pop(0)
             if current_fact.primary:
@@ -192,10 +192,10 @@ def _add_message_blocks(self, blocks: List[MessageBlock]) -> None:
 
     def _get_final_blocks(
         self, color: Optional[Color]
-    ) -> tuple[list[dict], list[dict]]:
+    ) -> Tuple[List[dict], List[dict]]:
         """
         Slack does not support coloring regular messages, only attachments.
-        Also, regular messages are allways displayed in full, while attachments show the first 5 blocks (with a "show more" button).
+        Also, regular messages are always displayed in full, while attachments show the first 5 blocks (with a "show more" button).
         The way we handle this is as follows:
         - If we have a divider block, everything up to it and including it is a regular message, and everything after it is an attachment.
         - If we don't have a divider block:

tests/unit/messages/formats/block_kit/fixtures/all_blocks_green.json

@@ -62,4 +62,4 @@
       "color": "#33b989"
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/all_blocks_no_color.json

@@ -61,4 +61,4 @@
       "blocks": []
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/all_blocks_red.json

@@ -62,4 +62,4 @@
       "color": "#ff0000"
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/all_blocks_yellow.json

@@ -62,4 +62,4 @@
       "color": "#ffcc00"
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/all_icons.json

@@ -13,4 +13,4 @@
       "blocks": []
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/bullet_list.json

@@ -20,4 +20,4 @@
       "blocks": []
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/code_block_200.json

@@ -13,4 +13,4 @@
       "blocks": []
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/code_block_50.json

@@ -13,4 +13,4 @@
       "blocks": []
     }
   ]
-}
+}

tests/unit/messages/formats/block_kit/fixtures/code_block_500.json

@@ -13,4 +13,4 @@
       "blocks": []
     }
   ]
-}
+}