Skip to content

Small Fixes to Docs#1800

Merged
Maayan-s merged 5 commits intoelementary-data:masterfrom
elazarlachkar:small-docs-fixes
Mar 31, 2025
Merged

Small Fixes to Docs#1800
Maayan-s merged 5 commits intoelementary-data:masterfrom
elazarlachkar:small-docs-fixes

Conversation

@elazarlachkar
Copy link
Copy Markdown
Contributor

Description

This pull request fixes 2 small things in Elementary's docs:

  1. Removes the duplicated intro and user creation steps from the Postgres DWH page.
  2. Changes the simple text Trino page to use a details card (like the ClickHouse and Athena pages).

Technical Changes

While running the docs server locally, I changed some technical minor things as well:

  1. Removed version section from the docker-compose.yaml as it's obsolete, and added quotes to the published ports as recommended.
  2. Upgraded Node version to solve the sharp module error on Linux runtime (v19 wasn't enough).
  3. Removed the mintlify install command from Dockerfile, apparently it was removed on v4 (see v3.0.98 docs vs v4.0.3 docs).

Tests

  • Built a new Docker image for the docs server.
  • Served the docs server locally using Docker-Compose.
  • Made sure the docs were changed as expected.

Notes for Reviewer

  • This PR is obviously not very important, feel free to ignore if you don't have time to deploy the changes.
  • I have no idea if the Trino "details card" subscription actually work, I just copied the ClickHouse URL and changed the query arg. Please validate it if you can.

@Maayan-s Maayan-s merged commit 1c55ea4 into elementary-data:master Mar 31, 2025
2 checks passed
hanalytics-data-service pushed a commit to hanalytics-data-service/hanalytics-elementary that referenced this pull request Apr 14, 2025
* Remove duplication from Postgres docs

* Replaced Trino text with details card

* Upgraded Node & Docker-Compose file

---------

Co-authored-by: ellakz <ella@elementary-data.com>
Co-authored-by: Maayan Salom <maayansalom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants