Ele 4261 clickhouse cli integration#1892
Merged
michael-myaskovsky merged 8 commits intomasterfrom Apr 16, 2025
Merged
Conversation
Contributor
|
👋 @michael-myaskovsky |
007d37d to
2f7331a
Compare
ofek1weiss
reviewed
Apr 14, 2025
| {%- if (test_type == 'dbt_test' and status in ['fail', 'warn']) or (test_type != 'dbt_test' and status in elementary_tests_allowlist_status) -%} | ||
| {% set test_rows_sample = elementary_cli.get_test_rows_sample(test.result_rows, test_result_rows_agate.get(test.id)) %} | ||
| {# Dimension anomalies return multiple dimensions for the test rows sample, and needs to be handle differently. #} | ||
| {# Currently we show only the anomalous for all of the dimensions. #} |
Contributor
There was a problem hiding this comment.
why did you remove the comments?
ofek1weiss
approved these changes
Apr 15, 2025
13fafae to
b0f4a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
null