Ele 4262 subscribers in the grouped alerts#1893
Merged
MikaKerman merged 4 commits intomasterfrom Apr 8, 2025
Merged
Conversation
MikaKerman
had a problem deploying
to
elementary_test_env
GitHub Actions
Error
Contributor
|
👋 @MikaKerman |
MikaKerman
had a problem deploying
to
elementary_test_env
GitHub Actions
Error
* Introduced MessageBuilderConfig to manage alert group subscribers. * Enhanced AlertMessageBuilder to conditionally display subscriber information based on configuration.
* Added `subscribers` parameter to various alert message test cases to ensure proper handling of subscriber data. * Introduced new fixture files for block kit and adaptive card formats reflecting subscriber details. * Updated existing fixture files to replace placeholder text for subscribers with actual subscriber information. * Enhanced `MessageBuilderConfig` integration to conditionally display subscriber information in alert messages.
…owners and subscribers * Modified alert message templates to replace singular terms with plural for owners and subscribers, ensuring clarity in communication. * Updated various test fixture files to reflect these changes, enhancing consistency across alert messages.
MikaKerman
force-pushed
the
ele-4262-subscribers-in-the-grouped-alerts
branch
from
3e5960e to
17622c9
Compare
MikaKerman
had a problem deploying
to
elementary_test_env
GitHub Actions
Error
ofek1weiss
reviewed
Apr 8, 2025
|
|
||
| if subscribers := list(set(alert.subscribers)): | ||
| if self.config.alert_groups_subscribers: | ||
| inlines.append(TextBlock(text="-")) |
Contributor
There was a problem hiding this comment.
only add it if there are owners.
also - a pipe (|) might look better here
MikaKerman
had a problem deploying
to
elementary_test_env
GitHub Actions
Failure
ofek1weiss
approved these changes
Apr 8, 2025
* Updated the AlertMessageBuilder to conditionally format the display of owners and subscribers, ensuring a consistent use of separators. * Adjusted test cases and fixture files to reflect the new formatting, enhancing the clarity of alert messages. * Modified the logic for subscriber handling to ensure proper display based on the presence of owners.
MikaKerman
force-pushed
the
ele-4262-subscribers-in-the-grouped-alerts
branch
from
858f2f8 to
ee7f319
Compare
MikaKerman
had a problem deploying
to
elementary_test_env
GitHub Actions
Error
MikaKerman
had a problem deploying
to
elementary_test_env
GitHub Actions
Failure
MikaKerman
force-pushed
the
ele-4262-subscribers-in-the-grouped-alerts
branch
from
a285ca0 to
ee7f319
Compare
MikaKerman
temporarily deployed
to
elementary_test_env
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds support for displaying subscribers in grouped alert messages, improving the visibility of who should be notified for different types of alerts.
Changes