Skip to content

Ele 4262 subscribers in the grouped alerts #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikaKerman merged 4 commits into from
Apr 8, 2025
Merged

Ele 4262 subscribers in the grouped alerts #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
943921d
MessageBuilderConfig
MikaKerman Apr 8, 2025
5c6b660
Update alert message tests to include subscriber information
MikaKerman Apr 8, 2025
17622c9
Update alert message formatting to consistently use plural terms for …
MikaKerman Apr 8, 2025
ee7f319
Refactor alert message formatting to improve clarity
MikaKerman Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions elementary/monitor/alerts/alert_messages/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
from datetime import timedelta
from typing import Any, Dict, List, Literal, Optional, Sequence, Tuple, Union

from pydantic import BaseModel

from elementary.messages.block_builders import (
BoldTextLineBlock,
BulletListBlock,
Expand All @@ -26,7 +28,6 @@
LineBlock,
LinesBlock,
LinkBlock,
MentionBlock,
TableBlock,
TextBlock,
TextStyle,
Expand All @@ -53,7 +54,14 @@
]


class MessageBuilderConfig(BaseModel):
alert_groups_subscribers: bool = False


class AlertMessageBuilder:
def __init__(self, config: Optional[MessageBuilderConfig] = None):
self.config = config or MessageBuilderConfig()

STATUS_DISPLAYS: Dict[str, str] = {
"fail": "Failure",
"warn": "Warning",
Expand Down Expand Up @@ -415,13 +423,19 @@ def _get_alert_list_line(
]
if owners := list(set(alert.owners)):
inlines.append(TextBlock(text="-"))
if len(owners) == 1:
inlines.append(TextBlock(text="Owner:"))
inlines.append(MentionBlock(user=owners.pop()))
else:
owners.sort()
inlines.append(TextBlock(text="Owners:"))
inlines.append(MentionLineBlock(*owners))
owners.sort()
inlines.append(TextBlock(text="Owners:"))
inlines.append(MentionLineBlock(*owners))

if self.config.alert_groups_subscribers:
if subscribers := list(set(alert.subscribers)):
if owners:
inlines.append(TextBlock(text="|"))
else:
inlines.append(TextBlock(text="-"))
subscribers.sort()
inlines.append(TextBlock(text="Subscribers:"))
inlines.append(MentionLineBlock(*subscribers))

if report_link := alert.get_report_link():
inlines.append(TextBlock(text="-"))
Expand Down
6 changes: 3 additions & 3 deletions elementary/monitor/dbt_project/package-lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
packages:
- package: dbt-labs/dbt_utils
version: 0.8.6
- git: https://github.com/elementary-data/dbt-data-reliability.git
revision: cc226bf865f922d6c4c5c6d65b2a142540e222f8
sha1_hash: a838112140dab39e15226f415d0b0bcbfbe311ff
- package: elementary-data/elementary
version: 0.18.2
sha1_hash: 0e32f8128c729542efc1b5c8e2c4fbe6f6534369
32 changes: 16 additions & 16 deletions ...est-errors-True_link-False_env-False.json → ...ink-False_env-False_subscribers-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,37 +41,37 @@
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_2** - Owners: owner1 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_4**",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_4** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_5** - Owners: owner1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_7**",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_7** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_8** - Owners: owner1 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
Expand All @@ -81,7 +81,7 @@
},
{
"type": "TextBlock",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_10**",
"text": "\u26a0\ufe0f **\"test_short_name\" test failed on test_table_10** - Subscribers: subscriber1",
"wrap": true
}
]
Expand All @@ -102,37 +102,37 @@
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owners: owner1 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_4**",
"text": "\u2757 **\"test_short_name\" test failed on test_table_4** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owners: owner1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_7**",
"text": "\u2757 **\"test_short_name\" test failed on test_table_7** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owners: owner1 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
Expand All @@ -142,7 +142,7 @@
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_10**",
"text": "\u2757 **\"test_short_name\" test failed on test_table_10** - Subscribers: subscriber1",
"wrap": true
}
]
Expand Down
16 changes: 8 additions & 8 deletions ...st-errors-False_link-False_env-False.json → ...ink-False_env-False_subscribers-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,37 +41,37 @@
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owners: owner1 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_4**",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_4** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owners: owner1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_7**",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_7** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owners: owner1 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
Expand All @@ -81,7 +81,7 @@
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_10**",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_10** - Subscribers: subscriber1",
"wrap": true
}
]
Expand Down
32 changes: 16 additions & 16 deletions ...est-errors-True_link-False_env-False.json → ...ink-False_env-False_subscribers-True.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,37 +41,37 @@
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_2** - Owners: owner1 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_4**",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_4** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_5** - Owners: owner1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_7**",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_7** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_8** - Owners: owner1 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
Expand All @@ -81,7 +81,7 @@
},
{
"type": "TextBlock",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_10**",
"text": "\ud83d\udd3a **\"test_short_name\" test failed on test_table_10** - Subscribers: subscriber1",
"wrap": true
}
]
Expand All @@ -102,37 +102,37 @@
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owner: owner1",
"text": "\u2757 **\"test_short_name\" test failed on test_table_2** - Owners: owner1 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2",
"text": "\u2757 **\"test_short_name\" test failed on test_table_3** - Owners: owner1, owner2 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_4**",
"text": "\u2757 **\"test_short_name\" test failed on test_table_4** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owner: owner1",
"text": "\u2757 **\"test_short_name\" test failed on test_table_5** - Owners: owner1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2",
"text": "\u2757 **\"test_short_name\" test failed on test_table_6** - Owners: owner1, owner2 | Subscribers: subscriber1",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_7**",
"text": "\u2757 **\"test_short_name\" test failed on test_table_7** - Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owner: owner1",
"text": "\u2757 **\"test_short_name\" test failed on test_table_8** - Owners: owner1 | Subscribers: subscriber1, subscriber2",
"wrap": true
},
{
Expand All @@ -142,7 +142,7 @@
},
{
"type": "TextBlock",
"text": "\u2757 **\"test_short_name\" test failed on test_table_10**",
"text": "\u2757 **\"test_short_name\" test failed on test_table_10** - Subscribers: subscriber1",
"wrap": true
}
]
Expand Down
Loading
Loading