Skip to content

Fix BigQuery scan for test result rows #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-myaskovsky merged 5 commits into from
Nov 18, 2025
Merged

Fix BigQuery scan for test result rows #1940

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62f8fe9
Add new macros for retrieving result rows in Agate
tlangton3 Jun 20, 2025
d5234ea
Merge branch 'master' into fix-bigquery-test_result_rows_scan
tlangton3 Jun 24, 2025
60fa3db
Merge branch 'master' into fix-bigquery-test_result_rows_scan
arbiv Nov 11, 2025
df4693f
pr comments
tlangton3 Nov 18, 2025
0b46e8b
Merge branch 'master' into fix-bigquery-test_result_rows_scan
michael-myaskovsky Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions elementary/monitor/dbt_project/macros/get_result_rows_agate.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{% macro get_result_rows_agate(days_back, valid_ids_query = none) %}
{% do return(adapter.dispatch('get_result_rows_agate', 'elementary')(days_back, valid_ids_query)) %}
{% endmacro %}

{% macro default__get_result_rows_agate(days_back, valid_ids_query = none) %}
{% set query %}
select
elementary_test_results_id,
Expand All @@ -15,3 +19,17 @@
{% endif %}
{% do return(res.group_by("elementary_test_results_id")) %}
{% endmacro %}

{% macro bigquery__get_result_rows_agate(days_back, valid_ids_query = none) %}
{% set query %}
select
elementary_test_results_id,
result_row
from {{ ref("elementary", "test_result_rows") }}
where detected_at >= {{ elementary.edr_timeadd('day', -1 * days_back, elementary.edr_current_timestamp()) }}
Copy link
Copy Markdown
Contributor

@michael-myaskovsky michael-myaskovsky Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
where detected_at >= {{ elementary.edr_timeadd('day', -1 * days_back, elementary.edr_current_timestamp()) }}
where detected_at > {{ elementary.edr_timeadd('day', -1 * days_back, elementary.edr_current_timestamp()) }}

for consistency with the default macro

Copy link
Copy Markdown
Contributor Author

@tlangton3 tlangton3 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

{% if valid_ids_query %}
and elementary_test_results_id in ({{ valid_ids_query }})
{% endif %}
{% endset %}
{% do return(elementary.run_query(query).group_by("elementary_test_results_id")) %}
{% endmacro %}
Comment thread
tlangton3 marked this conversation as resolved.
Loading