From f2780a44f9e00b8130d17212954e1a7b68de21d0 Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Tue, 28 Oct 2025 23:29:36 +0200 Subject: [PATCH 1/8] report: disable_samples should only affect dbt tests --- elementary/monitor/api/tests/tests.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/elementary/monitor/api/tests/tests.py b/elementary/monitor/api/tests/tests.py index e3f1165c8..810439890 100644 --- a/elementary/monitor/api/tests/tests.py +++ b/elementary/monitor/api/tests/tests.py @@ -444,10 +444,11 @@ def _get_test_result_from_test_result_db_row( ) -> Optional[Union[DbtTestResultSchema, ElementaryTestResultSchema]]: test_results: Optional[Union[DbtTestResultSchema, ElementaryTestResultSchema]] - sample_data = test_result_db_row.sample_data if not disable_samples else None if test_result_db_row.test_type == "dbt_test": - # Sample data is always a list for non-elementary tests - sample_data = cast(Optional[list], sample_data) + # Test result rows are always a list for non-elementary tests + sample_data = cast(Optional[list], test_result_db_row.sample_data) + if disable_samples: + sample_data = [] test_results = DbtTestResultSchema( display_name=test_result_db_row.test_name, @@ -460,14 +461,15 @@ def _get_test_result_from_test_result_db_row( "_", " " ).title() if test_result_db_row.test_type == "anomaly_detection": + metrics = test_result_db_row.sample_data if ( - isinstance(sample_data, list) + isinstance(metrics, list) and test_result_db_row.test_sub_type != "dimension" ): - sample_data.sort(key=lambda metric: metric.get("end_time")) + metrics.sort(key=lambda metric: metric.get("end_time")) test_results = ElementaryTestResultSchema( display_name=test_sub_type_display_name, - metrics=sample_data, + metrics=metrics, result_description=test_result_db_row.test_results_description, ) elif test_result_db_row.test_type == "schema_change": From 04aafb489bccaed6550f81062675a74c67e2314c Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Tue, 28 Oct 2025 23:30:29 +0200 Subject: [PATCH 2/8] update package dependency in CLI dbt project --- elementary/monitor/dbt_project/packages.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/elementary/monitor/dbt_project/packages.yml b/elementary/monitor/dbt_project/packages.yml index ce01a162c..a6468e49c 100644 --- a/elementary/monitor/dbt_project/packages.yml +++ b/elementary/monitor/dbt_project/packages.yml @@ -1,13 +1,13 @@ packages: - package: dbt-labs/dbt_utils version: [">=0.8.0", "<0.9.0"] - # - package: elementary-data/elementary - # version: 0.20.0 + - git: https://github.com/elementary-data/dbt-data-reliability.git + revision: d257bdda1793ecff1f65ba9684a0e962d3a77114 # NOTE - for unreleased CLI versions we often need to update the package version to a commit hash (please leave this # commented, so it will be easy to access) - - git: https://github.com/elementary-data/dbt-data-reliability.git - revision: 20b76374f7c1b6cc280af7652c720e6069499a19 - # When releasing a new version of the package, if the current version is using a commit hash, update the version to the new version. - #- package: elementary-data/elementary - # version: 0.20.0 + # - git: https://github.com/elementary-data/dbt-data-reliability.git + # revision: 20b76374f7c1b6cc280af7652c720e6069499a19 + # When releasing a new version of the package, if the current version is using a commit hash, update the version to the new version. + # - package: elementary-data/elementary + # version: 0.20.0 From 50fc5be0e1f8ae7ceb1baabd9c040141f37258f0 Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Tue, 28 Oct 2025 23:33:34 +0200 Subject: [PATCH 3/8] update package lock --- elementary/monitor/dbt_project/package-lock.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/elementary/monitor/dbt_project/package-lock.yml b/elementary/monitor/dbt_project/package-lock.yml index ba9e799d7..b7ff9f300 100644 --- a/elementary/monitor/dbt_project/package-lock.yml +++ b/elementary/monitor/dbt_project/package-lock.yml @@ -1,6 +1,8 @@ packages: - - package: dbt-labs/dbt_utils + - name: dbt_utils + package: dbt-labs/dbt_utils version: 0.8.6 - git: https://github.com/elementary-data/dbt-data-reliability.git - revision: 20b76374f7c1b6cc280af7652c720e6069499a19 -sha1_hash: 78546c8dc4ab641d9a66ebe04f4cd5818e4c0c37 + name: elementary + revision: d257bdda1793ecff1f65ba9684a0e962d3a77114 +sha1_hash: ae65942cf811d727a965b933552ce536a796f293 From 4dd71cef300609f87e298aac0c6e6a6738230eaa Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Tue, 28 Oct 2025 23:33:44 +0200 Subject: [PATCH 4/8] return old comment --- elementary/monitor/api/tests/tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elementary/monitor/api/tests/tests.py b/elementary/monitor/api/tests/tests.py index 810439890..6685428b6 100644 --- a/elementary/monitor/api/tests/tests.py +++ b/elementary/monitor/api/tests/tests.py @@ -445,7 +445,7 @@ def _get_test_result_from_test_result_db_row( test_results: Optional[Union[DbtTestResultSchema, ElementaryTestResultSchema]] if test_result_db_row.test_type == "dbt_test": - # Test result rows are always a list for non-elementary tests + # Sample data is always a list for non-elementary tests sample_data = cast(Optional[list], test_result_db_row.sample_data) if disable_samples: sample_data = [] From aa5cc877a1bd8d563f125b62a1386f545457a5bc Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Tue, 28 Oct 2025 23:34:30 +0200 Subject: [PATCH 5/8] remove name from package lock --- elementary/monitor/dbt_project/package-lock.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/elementary/monitor/dbt_project/package-lock.yml b/elementary/monitor/dbt_project/package-lock.yml index b7ff9f300..faa7887d7 100644 --- a/elementary/monitor/dbt_project/package-lock.yml +++ b/elementary/monitor/dbt_project/package-lock.yml @@ -1,8 +1,6 @@ packages: - - name: dbt_utils - package: dbt-labs/dbt_utils + - package: dbt-labs/dbt_utils version: 0.8.6 - git: https://github.com/elementary-data/dbt-data-reliability.git - name: elementary revision: d257bdda1793ecff1f65ba9684a0e962d3a77114 sha1_hash: ae65942cf811d727a965b933552ce536a796f293 From 284c5c6852cde8c35b7d570a3048f122dd07f6e6 Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Wed, 29 Oct 2025 13:12:01 +0200 Subject: [PATCH 6/8] update dbt package version --- elementary/monitor/dbt_project/packages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elementary/monitor/dbt_project/packages.yml b/elementary/monitor/dbt_project/packages.yml index a6468e49c..186a0a046 100644 --- a/elementary/monitor/dbt_project/packages.yml +++ b/elementary/monitor/dbt_project/packages.yml @@ -2,7 +2,7 @@ packages: - package: dbt-labs/dbt_utils version: [">=0.8.0", "<0.9.0"] - git: https://github.com/elementary-data/dbt-data-reliability.git - revision: d257bdda1793ecff1f65ba9684a0e962d3a77114 + revision: a01c958a3ee272b253d8e971e128c78a72b79239 # NOTE - for unreleased CLI versions we often need to update the package version to a commit hash (please leave this # commented, so it will be easy to access) From 8a191e744898bd8da2f8a2986d54678c39e21d06 Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Wed, 29 Oct 2025 13:13:48 +0200 Subject: [PATCH 7/8] update package-lock --- elementary/monitor/dbt_project/package-lock.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/elementary/monitor/dbt_project/package-lock.yml b/elementary/monitor/dbt_project/package-lock.yml index faa7887d7..7cf1cd441 100644 --- a/elementary/monitor/dbt_project/package-lock.yml +++ b/elementary/monitor/dbt_project/package-lock.yml @@ -2,5 +2,5 @@ packages: - package: dbt-labs/dbt_utils version: 0.8.6 - git: https://github.com/elementary-data/dbt-data-reliability.git - revision: d257bdda1793ecff1f65ba9684a0e962d3a77114 -sha1_hash: ae65942cf811d727a965b933552ce536a796f293 + revision: a01c958a3ee272b253d8e971e128c78a72b79239 +sha1_hash: c91170dd00244625c43a676e888c3a824eaeb28a From a37842623cc110a550ab26be14b05c6664932fe5 Mon Sep 17 00:00:00 2001 From: Itamar Hartstein Date: Wed, 29 Oct 2025 13:25:32 +0200 Subject: [PATCH 8/8] disable_samples - preserve previous behavior for dbt tests by setting to None --- elementary/monitor/api/tests/tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elementary/monitor/api/tests/tests.py b/elementary/monitor/api/tests/tests.py index 6685428b6..4d603a4ea 100644 --- a/elementary/monitor/api/tests/tests.py +++ b/elementary/monitor/api/tests/tests.py @@ -448,7 +448,7 @@ def _get_test_result_from_test_result_db_row( # Sample data is always a list for non-elementary tests sample_data = cast(Optional[list], test_result_db_row.sample_data) if disable_samples: - sample_data = [] + sample_data = None test_results = DbtTestResultSchema( display_name=test_result_db_row.test_name,