From f376ad0c69f6e7ec79e73f15c2f2a3d1fa49024b Mon Sep 17 00:00:00 2001 From: Elazar Lachkar Date: Wed, 14 Jan 2026 16:56:24 +0200 Subject: [PATCH 1/2] Reapply "Include seeds without tests in filters" This reverts commit c8ed0b2b58df5b6353299f68ceac914b441a21cf. --- elementary/monitor/api/filters/filters.py | 15 ++++++++++++--- elementary/monitor/api/report/report.py | 7 ++++++- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/elementary/monitor/api/filters/filters.py b/elementary/monitor/api/filters/filters.py index 1f73b5d24..8839451ec 100644 --- a/elementary/monitor/api/filters/filters.py +++ b/elementary/monitor/api/filters/filters.py @@ -5,6 +5,7 @@ from elementary.monitor.api.models.schema import ( ModelRunsSchema, NormalizedModelSchema, + NormalizedSeedSchema, NormalizedSourceSchema, ) from elementary.monitor.api.totals_schema import TotalsSchema @@ -25,11 +26,14 @@ def get_filters( models: Dict[str, NormalizedModelSchema], sources: Dict[str, NormalizedSourceSchema], models_runs: List[ModelRunsSchema], + seeds: Dict[str, NormalizedSeedSchema], ) -> FiltersSchema: test_results_filters = self._get_test_filters( - test_results_totals, models, sources + test_results_totals, models, sources, seeds + ) + test_runs_filters = self._get_test_filters( + test_runs_totals, models, sources, seeds ) - test_runs_filters = self._get_test_filters(test_runs_totals, models, sources) model_runs_filters = self._get_model_runs_filters(models_runs) return FiltersSchema( test_results=test_results_filters, @@ -42,6 +46,7 @@ def _get_test_filters( totals: Dict[str, TotalsSchema], models: Dict[str, NormalizedModelSchema], sources: Dict[str, NormalizedSourceSchema], + seeds: Dict[str, NormalizedSeedSchema], ) -> List[FilterSchema]: failures_filter = FilterSchema(name="failures", display_name="Failures") warnings_filter = FilterSchema(name="warnings", display_name="Warnings") @@ -50,7 +55,11 @@ def _get_test_filters( no_tests_filter = FilterSchema(name="no_test", display_name="No Tests") totals_models_ids = totals.keys() - artifacts: List[ArtifactSchema] = [*models.values(), *sources.values()] + artifacts: List[ArtifactSchema] = [ + *models.values(), + *sources.values(), + *seeds.values(), + ] for artifact in artifacts: if artifact.unique_id and artifact.unique_id not in totals_models_ids: no_tests_filter.add_model_unique_id(artifact.unique_id) diff --git a/elementary/monitor/api/report/report.py b/elementary/monitor/api/report/report.py index e70845039..072b70d80 100644 --- a/elementary/monitor/api/report/report.py +++ b/elementary/monitor/api/report/report.py @@ -161,7 +161,12 @@ def get_report_data( lineage_node_ids, exclude_elementary_models ) filters = filters_api.get_filters( - test_results_totals, test_runs_totals, models, sources, models_runs.runs + test_results_totals, + test_runs_totals, + models, + sources, + models_runs.runs, + seeds, ) serializable_groups = groups.dict() From e2fb7689f9aaa5f36726addaee524f6e36385715 Mon Sep 17 00:00:00 2001 From: Elazar Lachkar Date: Thu, 15 Jan 2026 09:13:50 +0200 Subject: [PATCH 2/2] Include Snapshots as well --- elementary/monitor/api/filters/filters.py | 8 ++++++-- elementary/monitor/api/report/report.py | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/elementary/monitor/api/filters/filters.py b/elementary/monitor/api/filters/filters.py index 8839451ec..b45bf69e9 100644 --- a/elementary/monitor/api/filters/filters.py +++ b/elementary/monitor/api/filters/filters.py @@ -6,6 +6,7 @@ ModelRunsSchema, NormalizedModelSchema, NormalizedSeedSchema, + NormalizedSnapshotSchema, NormalizedSourceSchema, ) from elementary.monitor.api.totals_schema import TotalsSchema @@ -27,12 +28,13 @@ def get_filters( sources: Dict[str, NormalizedSourceSchema], models_runs: List[ModelRunsSchema], seeds: Dict[str, NormalizedSeedSchema], + snapshots: Dict[str, NormalizedSnapshotSchema], ) -> FiltersSchema: test_results_filters = self._get_test_filters( - test_results_totals, models, sources, seeds + test_results_totals, models, sources, seeds, snapshots ) test_runs_filters = self._get_test_filters( - test_runs_totals, models, sources, seeds + test_runs_totals, models, sources, seeds, snapshots ) model_runs_filters = self._get_model_runs_filters(models_runs) return FiltersSchema( @@ -47,6 +49,7 @@ def _get_test_filters( models: Dict[str, NormalizedModelSchema], sources: Dict[str, NormalizedSourceSchema], seeds: Dict[str, NormalizedSeedSchema], + snapshots: Dict[str, NormalizedSnapshotSchema], ) -> List[FilterSchema]: failures_filter = FilterSchema(name="failures", display_name="Failures") warnings_filter = FilterSchema(name="warnings", display_name="Warnings") @@ -59,6 +62,7 @@ def _get_test_filters( *models.values(), *sources.values(), *seeds.values(), + *snapshots.values(), ] for artifact in artifacts: if artifact.unique_id and artifact.unique_id not in totals_models_ids: diff --git a/elementary/monitor/api/report/report.py b/elementary/monitor/api/report/report.py index 072b70d80..77850333e 100644 --- a/elementary/monitor/api/report/report.py +++ b/elementary/monitor/api/report/report.py @@ -167,6 +167,7 @@ def get_report_data( sources, models_runs.runs, seeds, + snapshots, ) serializable_groups = groups.dict()