From 3b74f13c47f320a4852689206e8241e0d5c5121a Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 27 Jan 2026 13:37:37 +0000 Subject: [PATCH 1/2] Run CLI tests on all warehouses instead of just Postgres - Add pull_request_target trigger to test-all-warehouses.yml - Add workflow_call trigger for reusability - Remove dbt 1.8.0 from matrix, run only on latest version - Update elementary-ref to use PR head SHA for pull_request_target events - Skip Slack notifications for PR failures to avoid spam - Delete test-main-warehouse.yml (superseded by test-all-warehouses.yml) Resolves ELE-5218 Co-Authored-By: Itamar Hartstein --- .github/workflows/test-all-warehouses.yml | 29 ++++++++++++++++++++--- .github/workflows/test-main-warehouse.yml | 17 ------------- 2 files changed, 26 insertions(+), 20 deletions(-) delete mode 100644 .github/workflows/test-main-warehouse.yml diff --git a/.github/workflows/test-all-warehouses.yml b/.github/workflows/test-all-warehouses.yml index 0db83777e..eacbf9609 100644 --- a/.github/workflows/test-all-warehouses.yml +++ b/.github/workflows/test-all-warehouses.yml @@ -1,5 +1,11 @@ name: Test all warehouse platforms on: + pull_request_target: + branches: ["master"] + paths: + - elementary/** + - .github/** + - pyproject.toml workflow_dispatch: inputs: elementary-ref: @@ -20,18 +26,34 @@ on: default: false description: Whether to generate new data + workflow_call: + inputs: + elementary-ref: + type: string + required: false + dbt-data-reliability-ref: + type: string + required: false + dbt-version: + type: string + required: false + generate-data: + type: boolean + required: false + default: false + jobs: test: strategy: fail-fast: false matrix: - dbt-version: ${{ inputs.dbt-version && fromJSON(format('["{0}"]', inputs.dbt-version)) || fromJSON('["1.8.0", null]') }} + dbt-version: ${{ inputs.dbt-version && fromJSON(format('["{0}"]', inputs.dbt-version)) || fromJSON('[null]') }} warehouse-type: [postgres, snowflake, bigquery, redshift, databricks_catalog, athena] uses: ./.github/workflows/test-warehouse.yml with: warehouse-type: ${{ matrix.warehouse-type }} - elementary-ref: ${{ inputs.elementary-ref }} + elementary-ref: ${{ inputs.elementary-ref || (github.event_name == 'pull_request_target' && github.event.pull_request.head.sha) || '' }} dbt-data-reliability-ref: ${{ inputs.dbt-data-reliability-ref }} dbt-version: ${{ matrix.dbt-version }} generate-data: ${{ inputs.generate-data || false }} @@ -45,7 +67,8 @@ jobs: always() && ! cancelled() && ! contains(needs.test.result, 'success') && - ! contains(needs.test.result, 'cancelled') + ! contains(needs.test.result, 'cancelled') && + github.event_name != 'pull_request_target' uses: ./.github/workflows/notify_slack.yml with: result: "failure" diff --git a/.github/workflows/test-main-warehouse.yml b/.github/workflows/test-main-warehouse.yml deleted file mode 100644 index 048443b0f..000000000 --- a/.github/workflows/test-main-warehouse.yml +++ /dev/null @@ -1,17 +0,0 @@ -name: Test main warehouse platform -on: - pull_request_target: - branches: ["master"] - paths: - - elementary/** - - .github/** - - pyproject.toml - workflow_dispatch: - -jobs: - test: - uses: ./.github/workflows/test-warehouse.yml - with: - warehouse-type: postgres - elementary-ref: ${{ (github.event_name == 'pull_request_target' && github.event.pull_request.head.sha) || '' }} - secrets: inherit From 1472a0301b98b1bb63431a7536e469abc968127d Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 27 Jan 2026 13:43:03 +0000 Subject: [PATCH 2/2] Remove workflow_call trigger (not used by any other workflow) Co-Authored-By: Itamar Hartstein --- .github/workflows/test-all-warehouses.yml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/.github/workflows/test-all-warehouses.yml b/.github/workflows/test-all-warehouses.yml index eacbf9609..6a969c825 100644 --- a/.github/workflows/test-all-warehouses.yml +++ b/.github/workflows/test-all-warehouses.yml @@ -26,22 +26,6 @@ on: default: false description: Whether to generate new data - workflow_call: - inputs: - elementary-ref: - type: string - required: false - dbt-data-reliability-ref: - type: string - required: false - dbt-version: - type: string - required: false - generate-data: - type: boolean - required: false - default: false - jobs: test: strategy: