Skip to content

Remove notify_failures from test-all-warehouses.yml#2105

Merged
haritamar merged 1 commit intomasterfrom
devin/1770668789-remove-notify-failures
Feb 10, 2026
Merged

Remove notify_failures from test-all-warehouses.yml#2105
haritamar merged 1 commit intomasterfrom
devin/1770668789-remove-notify-failures

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Feb 9, 2026 •
edited by coderabbitai Bot
Loading

Summary

Removes the notify_failures job from test-all-warehouses.yml. This job called notify_slack.yml to send Slack notifications on test failures, but it is not needed and currently creates irrelevant failures.

Review & Testing Checklist for Human

  • Confirm no other workflows or processes depend on the notify_failures job in this workflow
  • Check if .github/workflows/notify_slack.yml is still referenced elsewhere — if not, consider removing it in a follow-up

Notes

Summary by CodeRabbit

  • Chores
    • Removed Slack notification workflow for test completions.

@devin-ai-integration @haritamar
Remove notify_failures from test-all-warehouses.yml
fddf5b0 
Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration Bot commented Feb 9, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 9, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request removes a Slack notification workflow invocation from the test-all-warehouses workflow. The notify_failures step, which sent notifications to Slack upon test completion, has been deleted entirely from the workflow configuration.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/test-all-warehouses.yml		 Removed Slack notification step (notify_failures) that was triggered after test matrix completion, including workflow reference and input parameters (result, run_id, workflow_name).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A whisker of change, a notification gone,
No more Slack alerts when tests are done,
The pipeline runs clean, so swift and light,
Fewer distractions in the workflow night! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: removing the notify_failures step from the test-all-warehouses.yml workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1770668789-remove-notify-failures

No actionable comments were generated in the recent review. 🎉

Comment @coderabbitai help to get the list of available commands and usage tips.

@haritamar haritamar merged commit be75349 into master Feb 10, 2026
17 of 18 checks passed
@haritamar haritamar deleted the devin/1770668789-remove-notify-failures branch February 10, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NoyaArie NoyaArie NoyaArie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoyaArie @haritamar