.github/workflows/test-warehouse.yml (1)

120-131: Schema naming logic is well-designed with correct budget calculation.

The implementation correctly:

• Derives the hash from the same components as the concurrency group
• Uses echo -n to avoid hashing a trailing newline
• Applies lowercase before the character filter
• Respects the 63-character PostgreSQL limit with the calculated budget

One optional enhancement: multiple consecutive special characters in branch names become multiple underscores (e.g., feature/v2--hotfix → feature_v2__hotfix). If consistent formatting is desired, you could collapse them:

Optional: collapse consecutive underscores

-          SAFE_BRANCH=$(echo "${BRANCH_NAME}" | awk '{print tolower($0)}' | sed "s/[^a-z0-9]/_/g" | head -c 29)
+          SAFE_BRANCH=$(echo "${BRANCH_NAME}" | awk '{print tolower($0)}' | sed "s/[^a-z0-9]/_/g; s/__*/_/g" | head -c 29)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/test-warehouse.yml around lines 120 - 131, The SAFE_BRANCH
transformation currently lowercases and replaces non-alphanumerics with
underscores but leaves consecutive underscores; update the SAFE_BRANCH pipeline
(the command that produces SAFE_BRANCH used by CONCURRENCY_GROUP, SHORT_HASH and
SCHEMA_NAME) to collapse repeated underscores into a single underscore (e.g., by
adding a step such as running the output through a squeeze/dedup of underscores)
and then apply head -c 29 as before so the final SCHEMA_NAME still fits the
63-char PostgreSQL budget.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

.github/workflows/test-warehouse.yml (1)

120-134: Consider using explicit UTC for consistent timestamps across runners.

The schema naming logic is well-designed with accurate budget calculations. However, date +%y%m%d_%H%M uses the system timezone. While GitHub-hosted runners default to UTC, explicitly specifying UTC ensures consistency if runners are ever reconfigured or if self-hosted runners are used.

🔧 Suggested change for explicit UTC

-          DATE_STAMP=$(date +%y%m%d_%H%M)
+          DATE_STAMP=$(date -u +%y%m%d_%H%M)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/test-warehouse.yml around lines 120 - 134, The DATE_STAMP
generation uses the local system timezone; change it to explicit UTC so schema
timestamps are consistent across runners by updating how DATE_STAMP is created
(the DATE_STAMP variable used to build SCHEMA_NAME). Replace the current date
invocation with an explicit UTC invocation (e.g., use date -u or set TZ=UTC for
the command) so DATE_STAMP and consequently SCHEMA_NAME are always based on UTC.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.