Skip to content

fix: use py_<YYMMDD_HHMMSS>_<branch>_<hash> schema naming to prevent CI collisions #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haritamar merged 5 commits into from
Feb 28, 2026
Merged

fix: use py_<YYMMDD_HHMMSS>_<branch>_<hash> schema naming to prevent CI collisions #2126

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41c5055
fix: use py_<yymmdd>_<branch>_<hash> schema naming to prevent CI coll…
devin-ai-integration[bot] Feb 27, 2026
3f540f6
style: collapse consecutive underscores in SAFE_BRANCH (CodeRabbit ni…
devin-ai-integration[bot] Feb 27, 2026
415b35b
feat: add HHMM to schema timestamp for per-run uniqueness
devin-ai-integration[bot] Feb 27, 2026
4a3f43b
style: use explicit UTC for timestamp (date -u)
devin-ai-integration[bot] Feb 27, 2026
649af0b
style: add seconds to timestamp (YYMMDD_HHMMSS) per maintainer request
devin-ai-integration[bot] Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .github/workflows/test-warehouse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ jobs:
run:
working-directory: elementary
concurrency:
# This is what eventually defines the schema name in the data platform.
# Serialises runs for the same warehouse × dbt-version × branch.
# The schema name is derived from a hash of this group (see "Write dbt profiles").
group: tests_${{ inputs.warehouse-type }}_dbt_${{ inputs.dbt-version }}_${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
steps:
Expand Down Expand Up @@ -116,13 +117,26 @@ jobs:
env:
CI_WAREHOUSE_SECRETS: ${{ secrets.CI_WAREHOUSE_SECRETS || '' }}
run: |
DBT_VERSION=$(pip show dbt-core | grep -i version | awk '{print $2}' | sed 's/\.//g')
UNDERSCORED_REF_NAME=$(echo "${{ inputs.warehouse-type }}_dbt_${DBT_VERSION}_${BRANCH_NAME}" | awk '{print tolower($0)}' | head -c 40 | sed "s/[-\/]/_/g")
# Schema name = py_<YYMMDD_HHMMSS>_<branch≤19>_<8-char hash>
# The hash prevents collisions across concurrent jobs; the branch
# keeps it human-readable; the timestamp helps with stale schema
# cleanup and ensures each CI run gets a unique schema.
#
# Budget (PostgreSQL 63-char limit):
# py_(3) + timestamp(13) + _(1) + branch(≤19) + _(1) + hash(8) = 45
# + _elementary(11) + _gw7(4) = 60
CONCURRENCY_GROUP="tests_${{ inputs.warehouse-type }}_dbt_${{ inputs.dbt-version }}_${BRANCH_NAME}"
SHORT_HASH=$(echo -n "$CONCURRENCY_GROUP" | sha256sum | head -c 8)
SAFE_BRANCH=$(echo "${BRANCH_NAME}" | awk '{print tolower($0)}' | sed "s/[^a-z0-9]/_/g; s/__*/_/g" | head -c 19)
DATE_STAMP=$(date -u +%y%m%d_%H%M%S)
SCHEMA_NAME="py_${DATE_STAMP}_${SAFE_BRANCH}_${SHORT_HASH}"

echo "Schema name: $SCHEMA_NAME (branch='${BRANCH_NAME}', timestamp=${DATE_STAMP}, hash of concurrency group)"

python "${{ github.workspace }}/elementary/tests/profiles/generate_profiles.py" \
--template "${{ github.workspace }}/elementary/tests/profiles/profiles.yml.j2" \
--output ~/.dbt/profiles.yml \
--schema-name "py_$UNDERSCORED_REF_NAME"
--schema-name "$SCHEMA_NAME"

- name: Run Python package unit tests
run: pytest -vv tests/unit --warehouse-type ${{ inputs.warehouse-type }}
Expand Down
Loading