-
Notifications
You must be signed in to change notification settings - Fork 216
DBX Docs: Fix order of storage access options; Marked option 3 as legacy #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
38d37a7
7667d0c
2d83242
441f947
cc143f6
6756e17
dc0df38
ef84ced
290af73
4d76cdd
31d32f7
fc01bd3
658b107
9ab1f9d
e3ae833
f8d2904
50a4f8b
c0bbb96
3ed28c7
9cd6245
bfb7314
48793ef
a354246
84eb161
3dee46a
563ed64
8c92a6a
57837d0
1d1d1fd
22374ca
dd03322
4ca2fd4
fa1f93c
907acab
9a2ba98
a7bfdc2
869f3af
f56e7bc
d1b67af
2160294
51c86ae
205e2b4
a94adb8
067a1e7
2b5f52a
870c274
3e90f88
ab8dcd1
be6e9fb
c32b099
70c862c
2037230
95ef4cc
c5fa3f4
72aeae8
30ecb65
b0c50a0
2bf67be
660b707
d6b5887
6dda479
239ac85
beab318
9f411e9
8899732
c41f3b7
6cd6533
b49751d
3c37b8f
bc7392a
0e6b0f5
916c728
9e4e228
a9d65be
0516fd6
f12953f
98b7042
c20abec
9a3f7e0
3de7c3e
4dfaba7
e9c8875
1522154
8f95bdf
809d7f4
11307cc
a761132
f7e7397
94244b9
5760aa0
ad12cc9
f62af62
f3b2b59
b24ee52
3b8d789
689e6df
20577d8
f6a6794
a0fb67f
b7fd908
15c2703
53e1185
c212516
dd7ae7d
1b375a5
dfe0f3d
02f46d1
ca1a946
d89dc18
c238ecc
4eb8dd2
519337b
4dd5aaf
1b2c133
dbec2fa
81760d2
57119eb
dc56336
1318440
5416f89
baaddd3
f3ae2c5
530d767
19e8f53
ea7a0a7
9ca521e
67a1a0e
bbe5412
9c7e3d3
307341e
f5518e1
79a1e3c
4c83e88
0aaf93e
5cb146a
4c090ca
68b3d00
d53e8f8
158de59
40d7280
3cef3a9
1867c9c
4655725
ace00de
9eae8cb
fa5f050
7751328
f7c70af
b273b44
1c86164
2c41617
10f42b1
d0ad4a3
f023c67
ec3f3ec
33694d1
2231c33
1264060
99c5118
0283d10
7c2f073
049c676
355bdfd
1e9c87d
7780531
fa6ead5
0d7589e
350faf4
b5fe281
f4cc83d
b83cc77
7413656
81afa12
a880709
52c568a
84cc6f3
f45262d
31884a3
9c77d81
e37213b
a4e28cf
4121a3f
1cb1104
5c87e06
3fa8fe2
61a7c96
a7d2d0c
5546b68
273ac06
aa961aa
304bea7
acbc00a
ca83cf9
bdb0191
bc194d8
9ed146e
fde8e91
143dbc8
a43db28
5897da3
6aa4c3d
55d9db3
5469066
b6e2d3c
b608efd
bfd4e22
907643f
5c3e713
bdcf436
36ed16b
34355d2
d0d4b98
9135dc7
273f21e
b276d6d
4372402
b4d3183
bad3197
2cd4cba
6e57e6d
a044c25
04aee72
cd1414f
c41b014
9168cbe
a38b0fc
7644749
b2f9284
62072f3
03d55bb
dca0c8c
3dcd8da
edefc8a
996d910
ad5a5ca
2153f60
688a7a8
ab0b4bc
89b738b
07151d0
c2ba6f7
5bdc069
9b80cde
e92947e
5f37d40
2f50257
822f307
8f53f2a
b7a40a7
4eab9ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| description: Writing guide for Elementary documentation | ||
| globs: docs/**/* | ||
| alwaysApply: false | ||
| --- | ||
|
|
||
| Before writing or editing any documentation in the `docs/` folder, read `docs/skills.md`. It is the single source of truth for writing style, page structure, component usage, image conventions, and the checklist of all places to update when adding a feature or integration. | ||
|
|
||
| Follow it for every docs task. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,3 +97,4 @@ venv/ | |
|
|
||
| # elementary outputs | ||
| edr_target/ | ||
| dbt_packages/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ pre-commit | |
| mypy | ||
|
|
||
| # MyPy stubs | ||
| types-pkg-resources | ||
| types-requests | ||
| networkx-stubs | ||
| types-python-dateutil | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Elementary Docs — Writing Guide | ||
|
|
||
| Before writing or editing any documentation in this folder, read `docs/skills.md`. It is the single source of truth for writing style, page structure, component usage, image conventions, and the checklist of all places to update when adding a feature or integration. | ||
|
|
||
| Follow it for every docs task. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,7 @@ | ||
| FROM node:19 | ||
| FROM node:20.3.0 | ||
|
|
||
| WORKDIR /app | ||
| RUN npm i -g mintlify | ||
| RUN mintlify install | ||
|
|
||
| EXPOSE 3000 | ||
| CMD ["mintlify", "dev"] |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Pre-commit mintlify hook missing
filesfilter blocks all commits for developers without mintlifyThe new
mintlify-validatepre-commit hook at.pre-commit-config.yaml:47-54has nofilesfilter, so it triggers on every commit regardless of which files changed. Sincelanguage: systemrequiresmintlify(a Node.js CLI tool) to be available onPATH, any developer who follows the CONTRIBUTING.md instructions (pre-commit install) but doesn't have mintlify installed globally will have all commits blocked — even pure Python changes. The other existing hooks either target specific file patterns (e.g.files: ^elementary/.*\.py$for mypy) or are language-agnostic. Addingfiles: ^docs/would scope the hook to documentation changes only.Was this helpful? React with 👍 or 👎 to provide feedback.