Skip to content

Put Greeter below all windows#2863

Merged
lenemter merged 4 commits into
mainfrom
lenemter/support-greeter
Jul 25, 2026
Merged

Put Greeter below all windows#2863
lenemter merged 4 commits into
mainfrom
lenemter/support-greeter

Conversation

@lenemter

@lenemter lenemter commented Jul 7, 2026

Copy link
Copy Markdown
Member

Required for elementary/greeter#878
Requires elementary/greeter#886
Requires elementary/greeter#893

Makes Greeter unmovable and puts it below apps such as Initial Setup

@lenemter
lenemter requested review from a team and leolost2605 July 7, 2026 22:51
@lenemter
lenemter force-pushed the lenemter/support-greeter branch 3 times, most recently from b94f449 to c9480d6 Compare July 8, 2026 00:14

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree with the separate group and making it desktop but (going from previous experience with our wayland protocols just organically growing) I would like to have some bigger picture where we want to take the greeter before deciding on the wayland protocol (which is why I haven't added it in the initial PR yet).
Most notably what we want to do with multiple monitors:

  • Greeter on primary?
  • Greeter on current?
  • Greeter on every monitor?

I've been thinking we might need greeter on every monitor because most notably for touchscreen we don't have a current monitor. I'm thinking of the case "connect tablet to external monitor without any accessories". Then in theory the only way to be 100% sure to be able to log in would be having it on every monitor. But I would definitely like some opinions from @elementary/ux on this

@lenemter
lenemter force-pushed the lenemter/support-greeter branch from c9480d6 to 67f286e Compare July 8, 2026 16:50
@lenemter

lenemter commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@leolost2605 My idea here is to let Gala decide what to do with Greeter windows, since there's no point in letting Greeter control all of this, since it's the only user of that protocol

@danirabbit

Copy link
Copy Markdown
Member

@leolost2605 I agree I think it would make sense to have the greeter on all displays. I think @lenemter is right though that probably the greeter app should just declare itself as a greeter and Gala should control what that means

@leolost2605

Copy link
Copy Markdown
Member

My idea here is to let Gala decide what to do with Greeter windows

Yeah I agree I just wanted to make sure that there's nothing that needs integration between greeter and gala. I had the monitor labels in mind because they need to specify what monitor they belong to but ig the greeter should be the same for all monitors? Anything else that might need integration?

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits (sorry about all of the order nits but since we've done it like that for all other methods and additions I think we should keep it here too)

Also I've been thinking since we make the greeter a desktop window anyway do we still need to put it into a separate group?

Comment thread lib/WindowManager.vala Outdated
Comment thread protocol/pantheon-desktop-shell-v1.xml Outdated
Comment thread protocol/pantheon-desktop-shell.vapi Outdated
Comment thread protocol/pantheon-desktop-shell.vapi Outdated
Comment thread protocol/pantheon-desktop-shell.vapi Outdated
Comment thread src/ShellClients/ShellClientsManager.vala Outdated
Comment thread src/PantheonShell.vala Outdated
Comment thread src/PantheonShell.vala Outdated
Comment thread src/PantheonShell.vala Outdated
Comment thread src/PantheonShell.vala Outdated
@danirabbit danirabbit added this to OS 9 Jul 20, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Jul 20, 2026
@lenemter
lenemter force-pushed the lenemter/support-greeter branch 2 times, most recently from c8364d0 to 713f246 Compare July 24, 2026 07:14
@lenemter

Copy link
Copy Markdown
Member Author

@leolost2605 Done

@lenemter
lenemter requested a review from leolost2605 July 24, 2026 07:42
@lenemter lenemter changed the title Put Greeter in a separate group Put Greeter below all windows Jul 24, 2026

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments apart from that LGTM!

Comment thread src/ShellClients/ShellClientsManager.vala Outdated
Comment thread src/ShellClients/ShellClientsManager.vala Outdated
@lenemter
lenemter force-pushed the lenemter/support-greeter branch from e406cc6 to 17c20e6 Compare July 24, 2026 17:11
@lenemter
lenemter requested a review from leolost2605 July 24, 2026 17:11
lenemter added a commit to elementary/greeter that referenced this pull request Jul 25, 2026

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@lenemter
lenemter merged commit 3427f37 into main Jul 25, 2026
6 checks passed
@lenemter
lenemter deleted the lenemter/support-greeter branch July 25, 2026 13:41
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants