From 29838f9c8b5fb38ad3249c115d96f40041cb8b82 Mon Sep 17 00:00:00 2001 From: Ryo Nakano Date: Thu, 14 Aug 2025 08:53:42 +0900 Subject: [PATCH 1/2] rfkill: Use sizeof instead of literal size --- src/rfkill.vala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rfkill.vala b/src/rfkill.vala index 840d4479..8d1f071f 100644 --- a/src/rfkill.vala +++ b/src/rfkill.vala @@ -28,7 +28,7 @@ public class RFKillDevice { event.idx = idx; event.op = RFKillOperation.CHANGE; event.soft = value ? 1 : 0; - if (Posix.write (manager.fd, &event, 8) != 8) + if (Posix.write (manager.fd, &event, sizeof (event)) != sizeof (event)) return; } } @@ -139,7 +139,7 @@ public class RFKillManager : Object { event.type = type; event.op = RFKillOperation.CHANGE_ALL; event.soft = lock_enabled ? 1 : 0; - if (Posix.write (fd, &event, 8) != 8) + if (Posix.write (fd, &event, sizeof (event)) != sizeof (event)) return; } @@ -148,7 +148,7 @@ public class RFKillManager : Object { private bool read_event () { var event = RFKillEvent (); - if (Posix.read (fd, &event, 8) != 8) + if (Posix.read (fd, &event, sizeof (event)) != sizeof (event)) return false; switch (event.op) { From 185298175f084c3503203940f0d9e292829d3722 Mon Sep 17 00:00:00 2001 From: Ryo Nakano Date: Thu, 14 Aug 2025 08:58:51 +0900 Subject: [PATCH 2/2] Make valac happy --- src/rfkill.vala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rfkill.vala b/src/rfkill.vala index 8d1f071f..5e918f70 100644 --- a/src/rfkill.vala +++ b/src/rfkill.vala @@ -28,7 +28,7 @@ public class RFKillDevice { event.idx = idx; event.op = RFKillOperation.CHANGE; event.soft = value ? 1 : 0; - if (Posix.write (manager.fd, &event, sizeof (event)) != sizeof (event)) + if (Posix.write (manager.fd, &event, sizeof (RFKillEvent)) != sizeof (RFKillEvent)) return; } } @@ -139,7 +139,7 @@ public class RFKillManager : Object { event.type = type; event.op = RFKillOperation.CHANGE_ALL; event.soft = lock_enabled ? 1 : 0; - if (Posix.write (fd, &event, sizeof (event)) != sizeof (event)) + if (Posix.write (fd, &event, sizeof (RFKillEvent)) != sizeof (RFKillEvent)) return; } @@ -148,7 +148,7 @@ public class RFKillManager : Object { private bool read_event () { var event = RFKillEvent (); - if (Posix.read (fd, &event, sizeof (event)) != sizeof (event)) + if (Posix.read (fd, &event, sizeof (RFKillEvent)) != sizeof (RFKillEvent)) return false; switch (event.op) {