Skip to content

Sidebar: use Action, search on type #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeebok merged 2 commits into from
Jun 4, 2025
Merged

Sidebar: use Action, search on type #251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
456de92
Sidebar: use Action, search on type
danirabbit May 10, 2025
cd76e13
Merge branch 'main' into danirabbit/sidebar-searchkeys
zeebok Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/Sidebar.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@ public class Applications.Sidebar : Gtk.Box {
margin_end = 6,
hexpand = true
};
search_entry.set_key_capture_widget (this);

var search_revealer = new Gtk.Revealer () {
child = search_entry
};

var search_toggle = new Gtk.ToggleButton () {
action_name = "sidebar.search",
icon_name = "edit-find-symbolic",
tooltip_text = _("Search Apps")
};
Expand Down Expand Up @@ -92,19 +94,31 @@ public class Applications.Sidebar : Gtk.Box {
}
});

search_entry.search_changed.connect (() => {
listbox.invalidate_filter ();
});
var search_action = new SimpleAction.stateful ("search", null, new Variant.boolean (false));
search_action.change_state.connect ((value) => {
search_action.set_state (value);

search_toggle.bind_property ("active", search_revealer, "reveal-child");
search_revealer.reveal_child = value.get_boolean ();

search_revealer.notify["child-revealed"].connect (() => {
if (search_revealer.child_revealed) {
if (value.get_boolean ()) {
search_entry.grab_focus ();
} else {
search_entry.text = "";
}
});

var action_group = new SimpleActionGroup ();
action_group.add_action (search_action);

insert_action_group ("sidebar", action_group);

search_entry.search_changed.connect (() => {
if (search_entry.text != "") {
search_action.change_state (new Variant.boolean (true));
}

listbox.invalidate_filter ();
});
}

private bool filter_function (Gtk.ListBoxRow row) {
Expand Down