Fix empty "Applications" tab#299
Merged
Merged
Conversation
ryonakano
reviewed
Feb 8, 2026
- Fixes #290 - Was introducted by #280 - Skipped application when PROP_APPLICATION_ID was absent, which never seems to be set - Skipped application when PROP_APPLICATION_NAME was absent. It was because from_sink_input_info() previously did not handle it - Add "Bluetooth Device", "Device" or "Unknown" entry depending on input properties
flodavid
force-pushed
the
fix-apps-not-shown
branch
2 times, most recently
from
caa70f3 to
dbaae94
Compare
Contributor
Author
|
I also fixed the default position for the toggles: |
Member
Is this another issue? Would you open a separate PR if so? |
Contributor
Author
|
Yes it is another issue, but since applications did not appear, it was not visible, so I thought I could include it as well, but a can make a separate PR |
flodavid
force-pushed
the
fix-apps-not-shown
branch
from
dbaae94 to
8261fc6
Compare
Contributor
Author
|
@ryonakano moved the commit to #300 |
ryonakano
approved these changes
Feb 15, 2026
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
LGTM and works as expected. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It skipped adding an application when
PROP_APPLICATION_IDwas absent, which never seems to be set.It also skipped adding an application when
PROP_APPLICATION_NAMEwas absent. It was becausefrom_sink_input_info()previously did not handle it.I tested by first reverting #280 and reproducing the crash it prevented by connecting a smartphone. Then I handled the absent application name inside
from_sink_input_info(). Doing this prevents the crash and allows to show devices as "applications".Result:
