Skip to content

UserSettingsView: use switch for locking account#259

Open
danirabbit wants to merge 8 commits into
mainfrom
danirabbit/usersettingsview-disableswitch
Open

UserSettingsView: use switch for locking account#259
danirabbit wants to merge 8 commits into
mainfrom
danirabbit/usersettingsview-disableswitch

Conversation

@danirabbit
Copy link
Copy Markdown
Member

@danirabbit danirabbit commented Sep 21, 2025

Can be rebase merged if desired

  • Uses an action to manage account lock state and sensitivity
  • Uses a switch instead of a text button in line with other settings panes
  • Change primary tooltip text to be state agnostic. Avoids a situation where it reads "Disable Account checkbox checked" which is pretty difficult to figure out whether that means the account is disabled or not
  • Make sure we use accurate secondary tooltip text
Screenshot from 2025-09-21 12 01 26

@danirabbit danirabbit requested a review from a team September 21, 2025 19:02
@danirabbit danirabbit added this to OS 9 Sep 21, 2025
@danirabbit danirabbit moved this to Needs Review in OS 9 Sep 21, 2025
Comment on lines +115 to +117
disable_switch = new Gtk.Switch () {
action_name = "user.enable",
tooltip_text = _("Account Lock"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be named as something like lock_switch or at least enable_switch then?

Comment thread src/Views/UserSettingsView.vala Outdated
@danirabbit danirabbit removed this from OS 9 Dec 7, 2025
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Dec 7, 2025
@danirabbit danirabbit added this to OS 9 Jan 26, 2026
@danirabbit danirabbit removed this from OS 8.1.1 Jan 26, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Jan 26, 2026
@zeebok
Copy link
Copy Markdown

zeebok commented Apr 1, 2026

Do you think the enable switch should be more aligned with the username field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants