SecretItemRow: Delete secrets the recommended way#24
Conversation
|
Does this not delete all cards instead of just one? |
|
@davidmhewitt Not that I can see? It matches both the schema and the specific attributes of this secret |
|
@danrabbit No reviewers have been requested for this. Is it ready? |
|
I am not familiar with this code or libsecret so I need to take a bit of time to get myself up to speed. Will review as soon as I can. |
| "io.elementary.switchboard.wallet", Secret.SchemaFlags.NONE, | ||
| "brand", Secret.SchemaAttributeType.STRING, | ||
| "exp", Secret.SchemaAttributeType.STRING | ||
| ); |
There was a problem hiding this comment.
This copies code from elsewhere - maybe should be held in a shared class and accessed with e.g. WalletSchema.get_default () (?) Can be another PR though
| "exp", Secret.SchemaAttributeType.STRING | ||
| ); | ||
|
|
||
| Secret.password_clearv.begin (schema, secret_item.get_attributes (), null); |
There was a problem hiding this comment.
Deletes all cards with the same brand and expiry date (?) Can there be more than one?
Just confirmed that it is possible to add two cards with the same attributes but different number and CVC. Deleting one does delete both of them.
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Looks like we need more specific attributes to distinguish cards of same brand and expiry date (or prevent these being added)
|
@danirabbit Is this something you still want to work on? |
|
I think this whole repo can probably be archived since it was never used |
3 participants
Doesn't delete your whole keychain 👍