Skip to content

fix: handling of target for guides, tests using lgtm.toml#147

Merged
scastlara merged 4 commits into
mainfrom
add-issues-action
Sep 29, 2025
Merged

fix: handling of target for guides, tests using lgtm.toml#147
scastlara merged 4 commits into
mainfrom
add-issues-action

Conversation

@scastlara

@scastlara scastlara commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

This PR was originally just attempting to add issues integration to our lgtm action in the repo.

However, it uncovered that some tests were using the lgtm.toml file of the repo itself.

Fixing that (with a solution that was already used in part of the test suite), uncovered an issue in handling TARGET for reviewer guides: we were accepting git repositories as target, and so a good error message was not displayed to the user.

This PR fixes all these issues.

@github-actions github-actions Bot added the CI CI pipeline changes label Sep 29, 2025
@scastlara scastlara self-assigned this Sep 29, 2025
@github-actions

github-actions Bot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Coverage

Coverage for Python 3.13 •
FileStmtsMissCoverMissing
lgtm_ai
   __main__.py1411589%54, 167, 214–216, 234–235, 264–266, 289, 313–314, 316–317
   validators.py831087%35, 46, 104, 111–116, 130
TOTAL173013991% 

Tests Skipped Failures Errors Time
229 0 💤 0 ❌ 0 🔥 9.129s ⏱️

@github-actions

github-actions Bot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Coverage

Coverage for Python 3.12 •
FileStmtsMissCoverMissing
lgtm_ai
   __main__.py1411589%54, 167, 214–216, 234–235, 264–266, 289, 313–314, 316–317
   validators.py831087%35, 46, 104, 111–116, 130
TOTAL173013991% 

Tests Skipped Failures Errors Time
229 0 💤 0 ❌ 0 🔥 10.263s ⏱️

@scastlara scastlara changed the title ci: add issues integration to lgtm review action fix: handling of target for guides, tests using lgtm.toml Sep 29, 2025
@github-actions github-actions Bot added fix Fixes an issue or a bug and removed CI CI pipeline changes fix Fixes an issue or a bug labels Sep 29, 2025
@scastlara

Copy link
Copy Markdown
Collaborator Author

/lgtm review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦉 lgtm Review

Score: Nitpicks 🤓

🔍 Summary

This is a solid PR that improves the codebase in several ways. The refactoring of the TARGET argument into a configurable TargetParser class is a great improvement for modularity, and the fix to prevent local repositories from being used with the guide command is well-implemented. The changes to improve test isolation are also a welcome addition for the long-term health of the test suite.

However, there is one blocking issue in the evaluate_review_quality.py script. A call to the refactored _parse_target function is missing a required argument, which will cause the script to fail.

Please address the comment below. Once fixed, this PR will be in great shape to merge.

More information
  • Id: c665bd38d23e424c8a5db2c47c33bc66
  • Model: gemini-2.5-pro
  • Created at: 2025-09-29T07:48:10.376705+00:00
Usage summary
  • Request count: 2
  • Request tokens: 31,072
  • Response tokens: 6,416
  • Total tokens: 37,488

See the 📚 lgtm-ai repository for more information about lgtm.

Comment thread scripts/evaluate_review_quality.py Outdated
@scastlara
scastlara merged commit 4f4fdd2 into main Sep 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes an issue or a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants