Skip to content

fix: don't exit with code 1 when there is nothing to review#154

Merged
scastlara merged 1 commit into
mainfrom
cosmetic
Oct 1, 2025
Merged

fix: don't exit with code 1 when there is nothing to review#154
scastlara merged 1 commit into
mainfrom
cosmetic

Conversation

@scastlara

Copy link
Copy Markdown
Collaborator

It was surprising behavior, and some TT people complained to me (understandably).

This PR contains some additional cosmetic changes (docstrings and internal renames that don't matter).

image

@github-actions github-actions Bot added the fix Fixes an issue or a bug label Oct 1, 2025
@scastlara
scastlara changed the base branch from mcp to main October 1, 2025 08:21
@github-actions github-actions Bot added fix Fixes an issue or a bug and removed fix Fixes an issue or a bug labels Oct 1, 2025
@github-actions

github-actions Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Coverage

Coverage Report •
FileStmtsMissCoverMissing
lgtm_ai
   __main__.py1521590%55, 168, 221–223, 241–242, 278–280, 303, 327–328, 330–331
lgtm_ai/config
   handler.py143199%219
lgtm_ai/formatters
   base.py100100% 
   json.py16287%22, 26
   markdown.py510100% 
   pretty.py381073%18, 48, 62, 75–76, 83, 87, 95, 99, 105
lgtm_ai/git
   parser.py53296%90–91
lgtm_ai/git_client
   gitlab.py1592087%42–44, 63–64, 88–89, 95–96, 112–114, 123–124, 129–130, 133, 212, 245–246
lgtm_ai/jira
   jira.py65395%37–39
lgtm_ai/mcp
   __main__.py39782%4–5, 54, 87, 90–91, 95
lgtm_ai/review
   context.py1061883%66–68, 72, 97, 129–130, 133–134, 145, 148–149, 157–162
   guide.py35197%38
   reviewer.py61493%96–98, 100
TOTAL179914691% 

Tests Skipped Failures Errors Time
237 1 💤 0 ❌ 0 🔥 10.755s ⏱️

@scastlara
scastlara merged commit 3ab611e into main Oct 1, 2025
7 checks passed
@scastlara
scastlara deleted the cosmetic branch October 2, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes an issue or a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants